Re: [PATCH] drm/qxl: Fix build errors

2020-08-18 Thread Dave Airlie
On Tue, 18 Aug 2020 at 15:32, Gerd Hoffmann wrote: > > Hi, > > > I guess things are never quite so easy :-). It looks like Daniel's > > patch is in drm-misc-fixes and Sidong's patch is in drm-misc-next. On > > their own they're fine, but once they are merged in drm-tip the build > > error shows

Re: [PATCH] drm/qxl: Fix build errors

2020-08-17 Thread Gerd Hoffmann
Hi, > I guess things are never quite so easy :-). It looks like Daniel's > patch is in drm-misc-fixes and Sidong's patch is in drm-misc-next. On > their own they're fine, but once they are merged in drm-tip the build > error shows up. Ah, ok. I've already wondered how that got past my build te

Re: [PATCH] drm/qxl: Fix build errors

2020-08-17 Thread Sean Paul
On Mon, Aug 17, 2020 at 4:09 PM Sean Paul wrote: > > On Mon, Aug 17, 2020 at 4:05 PM Sam Ravnborg wrote: > > > > Hi Sean. > > > > On Mon, Aug 17, 2020 at 03:58:38PM -0400, Sean Paul wrote: > > > From: Sean Paul > > > > > > Introduced in the patch below, the END macro was missing 'dev' and BEGIN

Re: [PATCH] drm/qxl: Fix build errors

2020-08-17 Thread Sean Paul
On Mon, Aug 17, 2020 at 4:05 PM Sam Ravnborg wrote: > > Hi Sean. > > On Mon, Aug 17, 2020 at 03:58:38PM -0400, Sean Paul wrote: > > From: Sean Paul > > > > Introduced in the patch below, the END macro was missing 'dev' and BEGIN > > macro needs drm_drv_uses_atomic_modeset() from drm_drv.h > > > >

Re: [PATCH] drm/qxl: Fix build errors

2020-08-17 Thread Sean Paul
On Mon, Aug 17, 2020 at 3:58 PM Sean Paul wrote: > > From: Sean Paul > > Introduced in the patch below, the END macro was missing 'dev' and BEGIN > macro needs drm_drv_uses_atomic_modeset() from drm_drv.h > > Fixes: bbaac1354cc9 ("drm/qxl: Replace deprecated function in qxl_display") > Cc: Sidong

Re: [PATCH] drm/qxl: Fix build errors

2020-08-17 Thread Sam Ravnborg
Hi Sean. On Mon, Aug 17, 2020 at 03:58:38PM -0400, Sean Paul wrote: > From: Sean Paul > > Introduced in the patch below, the END macro was missing 'dev' and BEGIN > macro needs drm_drv_uses_atomic_modeset() from drm_drv.h > > Fixes: bbaac1354cc9 ("drm/qxl: Replace deprecated function in qxl_dis

[PATCH] drm/qxl: Fix build errors

2020-08-17 Thread Sean Paul
From: Sean Paul Introduced in the patch below, the END macro was missing 'dev' and BEGIN macro needs drm_drv_uses_atomic_modeset() from drm_drv.h Fixes: bbaac1354cc9 ("drm/qxl: Replace deprecated function in qxl_display") Cc: Sidong Yang Cc: Gerd Hoffmann Cc: Dave Airlie Cc: virtualizat...@li