Re: [PATCH] drm/rockchip: dsi: Fix VOP selection on SoCs that support it

2022-10-29 Thread Heiko Stuebner
On Sun, 23 Oct 2022 18:07:47 +0200, Ondrej Jirman wrote: > lcdsel_grf_reg is defined as u32, so "< 0" comaprison is always false, > which breaks VOP selection on eg. RK3399. Compare against 0. > > Applied, thanks! [1/1] drm/rockchip: dsi: Fix VOP selection on SoCs that support it commit:

Re: [PATCH] drm/rockchip: dsi: Fix VOP selection on SoCs that support it

2022-10-24 Thread Chris Morgan
On Sun, Oct 23, 2022 at 06:07:47PM +0200, Ondrej Jirman wrote: > lcdsel_grf_reg is defined as u32, so "< 0" comaprison is always false, > which breaks VOP selection on eg. RK3399. Compare against 0. > Sorry about that. I can confirm this works for me on the rk3566 (specifically the Anbernic RG503

[PATCH] drm/rockchip: dsi: Fix VOP selection on SoCs that support it

2022-10-23 Thread Ondrej Jirman
lcdsel_grf_reg is defined as u32, so "< 0" comaprison is always false, which breaks VOP selection on eg. RK3399. Compare against 0. Fixes: f3aaa6125b6f ("drm/rockchip: dsi: add rk3568 support") Signed-off-by: Ondrej Jirman --- drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 4 +--- 1 file chan