Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread Johan Jonker
On 10/17/22 21:00, John Keeping wrote: > On Mon, Oct 17, 2022 at 08:30:23PM +0200, Johan Jonker wrote: >> >> >> On 10/17/22 13:29, Heiko Stuebner wrote: >>> Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: Hi Johan, On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan J

Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread John Keeping
On Mon, Oct 17, 2022 at 08:30:23PM +0200, Johan Jonker wrote: > > > On 10/17/22 13:29, Heiko Stuebner wrote: > > Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: > >> Hi Johan, > >> > >> On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote: > >>> Your patch contribution ca

Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread Johan Jonker
On 10/17/22 13:29, Heiko Stuebner wrote: > Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: >> Hi Johan, >> >> On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote: >>> Your patch contribution causes a kernel panic on MK808 with Rockchip >>> rk3066a SoC. >>> Would you li

Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread Heiko Stuebner
Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: > Hi Johan, > > On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote: > > Your patch contribution causes a kernel panic on MK808 with Rockchip > > rk3066a SoC. > > Would you like to contribute to fix this issue? > > The assu

Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread John Keeping
Hi Johan, On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote: > Your patch contribution causes a kernel panic on MK808 with Rockchip rk3066a > SoC. > Would you like to contribute to fix this issue? > The assumtion that drm_fbdev_generic_setup() does what > rockchip_drm_fbdev_init did i

[BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread Johan Jonker
Hi John, Your patch contribution causes a kernel panic on MK808 with Rockchip rk3066a SoC. Would you like to contribute to fix this issue? The assumtion that drm_fbdev_generic_setup() does what rockchip_drm_fbdev_init did is not true! A revert makes it work again. Johan == [7.975906]

Re: [PATCH] drm/rockchip: use generic fbdev setup

2021-12-07 Thread Thomas Zimmermann
Hi Am 07.12.21 um 12:54 schrieb John Keeping: Are you able to pick this up (and [1])? Otherwise what is needed here and who should pick this up? [1] https://lore.kernel.org/dri-devel/20211101114622.813536-1-j...@metanate.com/ I added both patches to drm-misc-next. Best regards Thomas --

Re: [PATCH] drm/rockchip: use generic fbdev setup

2021-12-07 Thread John Keeping
Hi Thomas, On Mon, Nov 01, 2021 at 11:34:15AM +, John Keeping wrote: > On Sun, 31 Oct 2021 19:09:39 +0100 > Thomas Zimmermann wrote: > > Am 30.10.21 um 14:05 schrieb John Keeping: > > > On Fri, Oct 29, 2021 at 09:00:08PM +0200, Thomas Zimmermann wrote: > > >> Am 29.10.21 um 13:50 schrieb Jo

Re: [PATCH] drm/rockchip: use generic fbdev setup

2021-11-01 Thread John Keeping
On Sun, 31 Oct 2021 19:09:39 +0100 Thomas Zimmermann wrote: > Am 30.10.21 um 14:05 schrieb John Keeping: > > On Fri, Oct 29, 2021 at 09:00:08PM +0200, Thomas Zimmermann wrote: > >> Am 29.10.21 um 13:50 schrieb John Keeping: > >>> The Rockchip fbdev code does not add anything compared to > >>>

Re: [PATCH] drm/rockchip: use generic fbdev setup

2021-10-31 Thread Thomas Zimmermann
Hi Am 30.10.21 um 14:05 schrieb John Keeping: Hi Thomas, On Fri, Oct 29, 2021 at 09:00:08PM +0200, Thomas Zimmermann wrote: Am 29.10.21 um 13:50 schrieb John Keeping: The Rockchip fbdev code does not add anything compared to drm_fbdev_generic_setup(); the one custom function for .fb_mmap does

Re: [PATCH] drm/rockchip: use generic fbdev setup

2021-10-30 Thread John Keeping
Hi Thomas, On Fri, Oct 29, 2021 at 09:00:08PM +0200, Thomas Zimmermann wrote: > Am 29.10.21 um 13:50 schrieb John Keeping: > > The Rockchip fbdev code does not add anything compared to > > drm_fbdev_generic_setup(); the one custom function for .fb_mmap does the > > same thing as gem_prime_mmap whi

Re: [PATCH] drm/rockchip: use generic fbdev setup

2021-10-29 Thread Thomas Zimmermann
Hi Am 29.10.21 um 13:50 schrieb John Keeping: The Rockchip fbdev code does not add anything compared to drm_fbdev_generic_setup(); the one custom function for .fb_mmap does the same thing as gem_prime_mmap which is called by the helper. Signed-off-by: John Keeping --- drivers/gpu/drm/rockchi

[PATCH] drm/rockchip: use generic fbdev setup

2021-10-29 Thread John Keeping
The Rockchip fbdev code does not add anything compared to drm_fbdev_generic_setup(); the one custom function for .fb_mmap does the same thing as gem_prime_mmap which is called by the helper. Signed-off-by: John Keeping --- drivers/gpu/drm/rockchip/Makefile | 1 - drivers/gpu/drm/ro