Re: [PATCH] drm/sched: Fix dynamic job-flow control race

2024-09-16 Thread Danilo Krummrich
On Mon, Sep 16, 2024 at 10:21:21AM +0200, Philipp Stanner wrote: > On Fri, 2024-09-13 at 09:53 -0700, Rob Clark wrote: > > From: Rob Clark > > > > Fixes a race condition reported here: > > https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 > > As Danilo suggested before, I'd

Re: [PATCH] drm/sched: Fix dynamic job-flow control race

2024-09-16 Thread Philipp Stanner
On Fri, 2024-09-13 at 09:53 -0700, Rob Clark wrote: > From: Rob Clark > > Fixes a race condition reported here: > https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 As Danilo suggested before, I'd put this in a Fixes: section at the bottom and instead have a sentence here det

Re: [PATCH] drm/sched: Fix dynamic job-flow control race

2024-09-14 Thread Michel Dänzer
On 2024-09-13 19:28, Rob Clark wrote: > On Fri, Sep 13, 2024 at 10:03 AM Michel Dänzer > wrote: >> >> On 2024-09-13 18:53, Rob Clark wrote: >>> From: Rob Clark >>> >>> Fixes a race condition reported here: >>> https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 >>> >>> The who

Re: [PATCH] drm/sched: Fix dynamic job-flow control race

2024-09-13 Thread Danilo Krummrich
On Fri, Sep 13, 2024 at 09:53:25AM -0700, Rob Clark wrote: > From: Rob Clark > > Fixes a race condition reported here: > https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 Good catch! Please add a 'Closes' tag with this link. > > The whole premise of lockless access to a s

Re: [PATCH] drm/sched: Fix dynamic job-flow control race

2024-09-13 Thread Rob Clark
On Fri, Sep 13, 2024 at 10:03 AM Michel Dänzer wrote: > > On 2024-09-13 18:53, Rob Clark wrote: > > From: Rob Clark > > > > Fixes a race condition reported here: > > https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 > > > > The whole premise of lockless access to a single-pr

Re: [PATCH] drm/sched: Fix dynamic job-flow control race

2024-09-13 Thread Michel Dänzer
On 2024-09-13 18:53, Rob Clark wrote: > From: Rob Clark > > Fixes a race condition reported here: > https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 > > The whole premise of lockless access to a single-producer-single- > consumer queue is that there is just a single produc

[PATCH] drm/sched: Fix dynamic job-flow control race

2024-09-13 Thread Rob Clark
From: Rob Clark Fixes a race condition reported here: https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 The whole premise of lockless access to a single-producer-single- consumer queue is that there is just a single producer and single consumer. That means we can't call dr