Re: [PATCH] drm/stm: repair runtime power management

2020-07-08 Thread Benjamin Gaignard
Le jeu. 2 juil. 2020 à 14:31, Philippe CORNU a écrit : > > > > On 2/29/20 11:16 PM, Marek Vasut wrote: > > Add missing pm_runtime_get_sync() into ltdc_crtc_atomic_enable() to > > match pm_runtime_put_sync() in ltdc_crtc_atomic_disable(), otherwise > > the LTDC might suspend via runtime PM,

Re: [PATCH] drm/stm: repair runtime power management

2020-07-03 Thread Marek Vasut
On 7/2/20 12:07 PM, Philippe CORNU wrote: Hi, [...] Thank for your patch. Pm_runtime_put_sync is also done into function ltdc_crtc_mode_fixup. To avoid several call of Pm_runtime_put_sync, it could be better to check pm_runtime activity: + int ret;

Re: [PATCH] drm/stm: repair runtime power management

2020-07-02 Thread Philippe CORNU
On 2/29/20 11:16 PM, Marek Vasut wrote: > Add missing pm_runtime_get_sync() into ltdc_crtc_atomic_enable() to > match pm_runtime_put_sync() in ltdc_crtc_atomic_disable(), otherwise > the LTDC might suspend via runtime PM, disable clock, and then fail > to resume later on. > > The test which

Re: [PATCH] drm/stm: repair runtime power management

2020-07-02 Thread Philippe CORNU
;> >>> -Original Message----- >>> From: Marek Vasut >>> Sent: samedi 29 février 2020 23:17 >>> To: dri-devel@lists.freedesktop.org >>> Cc: Marek Vasut ; Yannick FERTRE ; >>> Philippe CORNU ; Benjamin Gaignard >>> ; Vincent ABRIOU ; >>>

Re: [PATCH] drm/stm: repair runtime power management

2020-07-01 Thread Yannick FERTRE
Fertre > >> Best regards >> >> Yannick Fertré >> >> >> -Original Message- >> From: Marek Vasut >> Sent: samedi 29 février 2020 23:17 >> To: dri-devel@lists.freedesktop.org >> Cc: Marek Vasut ; Yannick FERTRE ; >> Philippe COR

Re: [PATCH] drm/stm: repair runtime power management

2020-03-10 Thread Marek Vasut
gt; Sent: samedi 29 février 2020 23:17 > To: dri-devel@lists.freedesktop.org > Cc: Marek Vasut ; Yannick FERTRE ; > Philippe CORNU ; Benjamin Gaignard > ; Vincent ABRIOU ; > Maxime Coquelin ; Alexandre TORGUE > ; linux-st...@st-md-mailman.stormreply.com; > linux-ar

RE: [PATCH] drm/stm: repair runtime power management

2020-03-09 Thread Yannick FERTRE
radead.org Subject: [PATCH] drm/stm: repair runtime power management Add missing pm_runtime_get_sync() into ltdc_crtc_atomic_enable() to match pm_runtime_put_sync() in ltdc_crtc_atomic_disable(), otherwise the LTDC might suspend via runtime PM, disable clock, and then fail to resume later on

[PATCH] drm/stm: repair runtime power management

2020-03-02 Thread Marek Vasut
Add missing pm_runtime_get_sync() into ltdc_crtc_atomic_enable() to match pm_runtime_put_sync() in ltdc_crtc_atomic_disable(), otherwise the LTDC might suspend via runtime PM, disable clock, and then fail to resume later on. The test which triggers it is roughly -- run qt5 application which uses