Re: [PATCH] drm/syncobj: Don't leak fences when WAIT_FOR_SUBMIT is set

2018-09-26 Thread Sean Paul
On Wed, Sep 26, 2018 at 02:17:03AM -0500, Jason Ekstrand wrote: > We attempt to get fences earlier in the hopes that everything will > already have fences and no callbacks will be needed. If we do succeed > in getting a fence, getting one a second time will result in a duplicate > ref with no unre

Re: [PATCH] drm/syncobj: Don't leak fences when WAIT_FOR_SUBMIT is set

2018-09-26 Thread Chris Wilson
Quoting Jason Ekstrand (2018-09-26 10:43:59) > On Wed, Sep 26, 2018 at 3:18 AM Chris Wilson wrote: > > Quoting Jason Ekstrand (2018-09-26 08:17:03) > > We attempt to get fences earlier in the hopes that everything will > > already have fences and no callbacks will be needed.  If we do

Re: [PATCH] drm/syncobj: Don't leak fences when WAIT_FOR_SUBMIT is set

2018-09-26 Thread Jason Ekstrand
On Wed, Sep 26, 2018 at 3:18 AM Chris Wilson wrote: > Quoting Jason Ekstrand (2018-09-26 08:17:03) > > We attempt to get fences earlier in the hopes that everything will > > already have fences and no callbacks will be needed. If we do succeed > > in getting a fence, getting one a second time wi

Re: [PATCH] drm/syncobj: Don't leak fences when WAIT_FOR_SUBMIT is set

2018-09-26 Thread Chris Wilson
Quoting Jason Ekstrand (2018-09-26 08:17:03) > We attempt to get fences earlier in the hopes that everything will > already have fences and no callbacks will be needed. If we do succeed > in getting a fence, getting one a second time will result in a duplicate > ref with no unref. This is causing

[PATCH] drm/syncobj: Don't leak fences when WAIT_FOR_SUBMIT is set

2018-09-26 Thread Jason Ekstrand
We attempt to get fences earlier in the hopes that everything will already have fences and no callbacks will be needed. If we do succeed in getting a fence, getting one a second time will result in a duplicate ref with no unref. This is causing memory leaks in Vulkan applications that create a lo