Re: [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2018-03-27 Thread Greg KH
On Mon, Mar 26, 2018 at 12:00:37PM -0700, Jason Ekstrand wrote: > From: Chris Wilson > > The vk cts test: > dEQP-VK.api.external.semaphore.opaque_fd.export_multiple_times_temporary > > triggers a lot of > VFS: Close: file count is 0 > > Dave pointed out that clearing the syncobj->file from > dr

Re: [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2018-03-26 Thread Jani Nikula
commit e7cdf5c82f1773c3386b93bbcf13b9bfff29fa31 upstream. BR, Jani. On Mon, 26 Mar 2018, Jason Ekstrand wrote: > From: Chris Wilson > > The vk cts test: > dEQP-VK.api.external.semaphore.opaque_fd.export_multiple_times_temporary > > triggers a lot of > VFS: Close: file count is 0 > > Dave point

[PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2018-03-26 Thread Jason Ekstrand
From: Chris Wilson The vk cts test: dEQP-VK.api.external.semaphore.opaque_fd.export_multiple_times_temporary triggers a lot of VFS: Close: file count is 0 Dave pointed out that clearing the syncobj->file from drm_syncobj_file_release() was sufficient to silence the test, but that opens a can of

Re: [Intel-gfx] [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-20 Thread Chris Wilson
Quoting Dave Airlie (2017-12-21 02:42:56) > > @@ -494,12 +473,11 @@ static int drm_syncobj_fd_to_handle(struct drm_file > > *file_private, > > spin_unlock(&file_private->syncobj_table_lock); > > idr_preload_end(); > > > > - if (ret < 0) { > > - fput(syncobj->fil

Re: [Intel-gfx] [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-20 Thread Dave Airlie
> @@ -494,12 +473,11 @@ static int drm_syncobj_fd_to_handle(struct drm_file > *file_private, > spin_unlock(&file_private->syncobj_table_lock); > idr_preload_end(); > > - if (ret < 0) { > - fput(syncobj->file); > - return ret; > - } > -

Re: [Intel-gfx] [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-19 Thread Daniel Vetter
On Tue, Dec 19, 2017 at 12:07:00PM +, Chris Wilson wrote: > The vk cts test: > dEQP-VK.api.external.semaphore.opaque_fd.export_multiple_times_temporary > > triggers a lot of > VFS: Close: file count is 0 > > Dave pointed out that clearing the syncobj->file from > drm_syncobj_file_release() wa

[PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-19 Thread Chris Wilson
The vk cts test: dEQP-VK.api.external.semaphore.opaque_fd.export_multiple_times_temporary triggers a lot of VFS: Close: file count is 0 Dave pointed out that clearing the syncobj->file from drm_syncobj_file_release() was sufficient to silence the test, but that opens a can of worm since we assume