[PATCH] drm/tegra: Fix crash caused by reference count imbalance

2016-05-18 Thread Daniel Vetter
On Wed, May 18, 2016 at 10:18:52AM +0100, Jon Hunter wrote: > > On 17/05/16 18:36, Daniel Vetter wrote: > > On Tue, May 17, 2016 at 7:29 PM, Jon Hunter wrote: > @@ -764,6 +769,9 @@ tegra_dsi_connector_duplicate_state(struct > drm_connector *connector) > if (!copy) >

[PATCH] drm/tegra: Fix crash caused by reference count imbalance

2016-05-18 Thread Jon Hunter
On 17/05/16 18:36, Daniel Vetter wrote: > On Tue, May 17, 2016 at 7:29 PM, Jon Hunter wrote: @@ -764,6 +769,9 @@ tegra_dsi_connector_duplicate_state(struct drm_connector *connector) if (!copy) return NULL; +if (copy->base.crtc) +

[PATCH] drm/tegra: Fix crash caused by reference count imbalance

2016-05-17 Thread Daniel Vetter
On Tue, May 17, 2016 at 7:29 PM, Jon Hunter wrote: >>> @@ -764,6 +769,9 @@ tegra_dsi_connector_duplicate_state(struct >>> drm_connector *connector) >>> if (!copy) >>> return NULL; >>> >>> +if (copy->base.crtc) >>> +drm_connector_reference(connector); >>> + >> >>

[PATCH] drm/tegra: Fix crash caused by reference count imbalance

2016-05-17 Thread Daniel Vetter
On Tue, May 17, 2016 at 05:27:15PM +0100, Jon Hunter wrote: > Commit d2307dea14a4 ("drm/atomic: use connector references (v3)") added > reference counting for DRM connectors and this caused a crash when > exercising system suspend on Tegra114 Dalmore. > > The Tegra DSI driver implements a Tegra

[PATCH] drm/tegra: Fix crash caused by reference count imbalance

2016-05-17 Thread Jon Hunter
On 17/05/16 17:46, Daniel Vetter wrote: > On Tue, May 17, 2016 at 05:27:15PM +0100, Jon Hunter wrote: >> Commit d2307dea14a4 ("drm/atomic: use connector references (v3)") added >> reference counting for DRM connectors and this caused a crash when >> exercising system suspend on Tegra114 Dalmore.

[PATCH] drm/tegra: Fix crash caused by reference count imbalance

2016-05-17 Thread Jon Hunter
Commit d2307dea14a4 ("drm/atomic: use connector references (v3)") added reference counting for DRM connectors and this caused a crash when exercising system suspend on Tegra114 Dalmore. The Tegra DSI driver implements a Tegra specific function, tegra_dsi_connector_duplicate_state(), to duplicate