Re: [PATCH] drm/ttm: Warn on pinning without holding a reference

2020-11-27 Thread Daniel Vetter
On Wed, Oct 28, 2020 at 01:11:51PM +0100, Christian König wrote: > Am 28.10.20 um 12:31 schrieb Daniel Vetter: > > Not technically a problem for ttm, but very likely a driver bug and > > pretty big time confusing for reviewing code. > > > > So warn about it, both at cleanup time (so we catch

Re: [PATCH] drm/ttm: Warn on pinning without holding a reference

2020-10-28 Thread Christian König
Am 28.10.20 um 12:31 schrieb Daniel Vetter: Not technically a problem for ttm, but very likely a driver bug and pretty big time confusing for reviewing code. So warn about it, both at cleanup time (so we catch these for sure) and at pin/unpin time (so we know who's the culprit). Signed-off-by:

Re: [PATCH] drm/ttm: Warn on pinning without holding a reference

2020-10-28 Thread Huang Rui
On Wed, Oct 28, 2020 at 07:31:20PM +0800, Daniel Vetter wrote: > Not technically a problem for ttm, but very likely a driver bug and > pretty big time confusing for reviewing code. > > So warn about it, both at cleanup time (so we catch these for sure) > and at pin/unpin time (so we know who's

[PATCH] drm/ttm: Warn on pinning without holding a reference

2020-10-28 Thread Daniel Vetter
Not technically a problem for ttm, but very likely a driver bug and pretty big time confusing for reviewing code. So warn about it, both at cleanup time (so we catch these for sure) and at pin/unpin time (so we know who's the culprit). Signed-off-by: Daniel Vetter Cc: Christian Koenig Cc: