Re: [PATCH] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl

2019-12-29 Thread yukuai (C)
On 2019/12/29 4:45, Markus Elfring wrote: v3d_submit_cl_ioctl call kfree() with variable 'bin' twice. I would prefer a wording like “kfree() was called for the same variable twice within an if branch.”. Fix it by removing the latter one. I find the wording “Delete a duplicate function ca

Re: [PATCH] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl

2019-12-29 Thread Markus Elfring
> v3d_submit_cl_ioctl call kfree() with variable 'bin' twice. I would prefer a wording like “kfree() was called for the same variable twice within an if branch.”. > Fix it by removing the latter one. I find the wording “Delete a duplicate function call.” more appropriate. Please add the tag “F

[PATCH] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl

2019-12-26 Thread yu kuai
v3d_submit_cl_ioctl call kfree() with variable 'bin' twice. Fix it by removing the latter one. Signed-off-by: yu kuai --- drivers/gpu/drm/v3d/v3d_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c index 549dde83408b..37515e47b4