Re: [PATCH] drm/vc4: hdmi: Fix pointer dereference before check

2022-11-07 Thread Ville Syrjälä
On Mon, Nov 07, 2022 at 09:26:30AM +0100, Maxime Ripard wrote: > On Wed, Nov 02, 2022 at 12:10:03PM +0100, José Expósito wrote: > > Hi Maxime, > > > > Thanks a lot for looking into the patch. > > > > On Wed, Nov 02, 2022 at 10:01:53AM +0100, Maxime Ripard wrote: > > > Hi, > > > > > > On Sat, Oct

Re: [PATCH] drm/vc4: hdmi: Fix pointer dereference before check

2022-11-07 Thread Maxime Ripard
On Wed, Nov 02, 2022 at 12:10:03PM +0100, José Expósito wrote: > Hi Maxime, > > Thanks a lot for looking into the patch. > > On Wed, Nov 02, 2022 at 10:01:53AM +0100, Maxime Ripard wrote: > > Hi, > > > > On Sat, Oct 29, 2022 at 11:34:13AM +0200, José Expósito wrote: > > > Commit 6bed2ea3cb38 ("d

Re: [PATCH] drm/vc4: hdmi: Fix pointer dereference before check

2022-11-02 Thread José Expósito
Hi Maxime, Thanks a lot for looking into the patch. On Wed, Nov 02, 2022 at 10:01:53AM +0100, Maxime Ripard wrote: > Hi, > > On Sat, Oct 29, 2022 at 11:34:13AM +0200, José Expósito wrote: > > Commit 6bed2ea3cb38 ("drm/vc4: hdmi: Reset link on hotplug") introduced > > the vc4_hdmi_reset_link() fu

Re: [PATCH] drm/vc4: hdmi: Fix pointer dereference before check

2022-11-02 Thread Maxime Ripard
Hi, On Sat, Oct 29, 2022 at 11:34:13AM +0200, José Expósito wrote: > Commit 6bed2ea3cb38 ("drm/vc4: hdmi: Reset link on hotplug") introduced > the vc4_hdmi_reset_link() function. This function dereferences the > "connector" pointer before checking whether it is NULL or not. > > Rework variable as

[PATCH] drm/vc4: hdmi: Fix pointer dereference before check

2022-10-29 Thread José Expósito
Commit 6bed2ea3cb38 ("drm/vc4: hdmi: Reset link on hotplug") introduced the vc4_hdmi_reset_link() function. This function dereferences the "connector" pointer before checking whether it is NULL or not. Rework variable assignment to avoid this issue. Fixes: 6bed2ea3cb38 ("drm/vc4: hdmi: Reset link