Re: [PATCH] drm/vkms: add alpha-premultiplied color blending

2020-08-25 Thread Melissa Wen
Hi Rodrigo, Thanks for the review! I just sent a v2 applying your suggestions. Best Regards, Melissa Wen Melissa Wen On Tue, Aug 25, 2020 at 12:04 AM Rodrigo Siqueira wrote: > > Hi Melissa, > > First of all, thanks a lot for your patch! > > Follows my inline comments. > > On 08/19, Melissa

Re: [PATCH] drm/vkms: add alpha-premultiplied color blending

2020-08-24 Thread Rodrigo Siqueira
Hi Melissa, First of all, thanks a lot for your patch! Follows my inline comments. On 08/19, Melissa Wen wrote: > The current VKMS blend function ignores alpha channel and just overwrites > vaddr_src with vaddr_dst. This XRGB approach triggers a warning when > running the

Re: [PATCH] drm/vkms: add alpha-premultiplied color blending

2020-08-20 Thread Pekka Paalanen
On Wed, 19 Aug 2020 17:53:36 -0300 Melissa Wen wrote: > The current VKMS blend function ignores alpha channel and just overwrites > vaddr_src with vaddr_dst. This XRGB approach triggers a warning when > running the kms_cursor_crc/cursor-alpha-transparent test case. In IGT > tests,

[PATCH] drm/vkms: add alpha-premultiplied color blending

2020-08-19 Thread Melissa Wen
The current VKMS blend function ignores alpha channel and just overwrites vaddr_src with vaddr_dst. This XRGB approach triggers a warning when running the kms_cursor_crc/cursor-alpha-transparent test case. In IGT tests, cairo_format_argb32 uses premultiplied alpha (according to documentation), so