Re: [PATCH] drm: Clear e after kfree in drm_mode_page_flip_ioctl

2017-03-30 Thread Daniel Vetter
On Thu, Mar 30, 2017 at 10:26:24AM -0400, Harry Wentland wrote: > Reviewed-by: Harry Wentland Thanks for the quick review, pushed to drm-misc. -Daniel > > On 2017-03-30 09:32 AM, Daniel Vetter wrote: > > With the explicit retry loop static analyzers get confused by the

Re: [PATCH] drm: Clear e after kfree in drm_mode_page_flip_ioctl

2017-03-30 Thread Harry Wentland
Reviewed-by: Harry Wentland On 2017-03-30 09:32 AM, Daniel Vetter wrote: With the explicit retry loop static analyzers get confused by the control flow and believe that e could be accessed after kfree. That's not possible, but it's non-obvious, so let's clear it to

[PATCH] drm: Clear e after kfree in drm_mode_page_flip_ioctl

2017-03-30 Thread Daniel Vetter
With the explicit retry loop static analyzers get confused by the control flow and believe that e could be accessed after kfree. That's not possible, but it's non-obvious, so let's clear it to NULL. We already cleared e = NULL at the top of the function, so this is all in line. Cc: Julia Lawall