[Intel-gfx] [PATCH] drm: Explicitly compute the last cacheline for clflush on range

2015-10-19 Thread Daniel Vetter
On Sun, Oct 18, 2015 at 05:07:06PM +0100, Chris Wilson wrote: > On Sun, Oct 18, 2015 at 02:07:13PM +0100, Chris Wilson wrote: > > > I couldn't spot the difference either. I am beginning to suspect it is > > > gcc as > > > > > > diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c

[Intel-gfx] [PATCH] drm: Explicitly compute the last cacheline for clflush on range

2015-10-18 Thread Chris Wilson
On Sun, Oct 18, 2015 at 02:07:13PM +0100, Chris Wilson wrote: > > I couldn't spot the difference either. I am beginning to suspect it is > > gcc as > > > > diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c > > index 6743ff7..c9097b5 100644 > > --- a/drivers/gpu/drm/drm_cache.c

[Intel-gfx] [PATCH] drm: Explicitly compute the last cacheline for clflush on range

2015-10-18 Thread Chris Wilson
On Sun, Oct 18, 2015 at 01:28:11PM +0100, Chris Wilson wrote: > On Sat, Oct 17, 2015 at 11:03:19PM +0300, Imre Deak wrote: > > On Fri, 2015-10-16 at 20:55 +0100, Chris Wilson wrote: > > > Fixes regression from > > > > > > commit afcd950cafea6e27b739fe7772cbbeed37d05b8b > > > Author: Chris Wilson

[PATCH] drm: Explicitly compute the last cacheline for clflush on range

2015-10-18 Thread Chris Wilson
On Sat, Oct 17, 2015 at 11:03:19PM +0300, Imre Deak wrote: > On Fri, 2015-10-16 at 20:55 +0100, Chris Wilson wrote: > > Fixes regression from > > > > commit afcd950cafea6e27b739fe7772cbbeed37d05b8b > > Author: Chris Wilson > > Date: Wed Jun 10 15:58:01 2015 +0100 > > > > drm: Avoid the dou

[PATCH] drm: Explicitly compute the last cacheline for clflush on range

2015-10-17 Thread Imre Deak
On Fri, 2015-10-16 at 20:55 +0100, Chris Wilson wrote: > Fixes regression from > > commit afcd950cafea6e27b739fe7772cbbeed37d05b8b > Author: Chris Wilson > Date: Wed Jun 10 15:58:01 2015 +0100 > > drm: Avoid the double clflush on the last cache line in > drm_clflush_virt_range() > > I'm

[PATCH] drm: Explicitly compute the last cacheline for clflush on range

2015-10-16 Thread Chris Wilson
Fixes regression from commit afcd950cafea6e27b739fe7772cbbeed37d05b8b Author: Chris Wilson Date: Wed Jun 10 15:58:01 2015 +0100 drm: Avoid the double clflush on the last cache line in drm_clflush_virt_range() I'm stumped. Looking at the loop we should be iterating over every cache line u