Re: [PATCH] drm: Make the decision to keep vblank irq enabled earlier

2017-03-24 Thread Chris Wilson
On Fri, Mar 24, 2017 at 04:16:28AM +0100, Mario Kleiner wrote: > Looks good to me. As a further optimization, i think we could move > the vblank_disable_fn() call outside/below the > spin_unlock_irqrestore for event_lock, as vblank_disable_fn() > doesn't need any locks held at call time, so

Re: [PATCH] drm: Make the decision to keep vblank irq enabled earlier

2017-03-23 Thread Mario Kleiner
On 03/23/2017 02:26 PM, Ville Syrjälä wrote: On Thu, Mar 23, 2017 at 07:51:06AM +, Chris Wilson wrote: We want to provide the vblank irq shadow for pageflip events as well as vblank queries. Such events are completed within the vblank interrupt handler, and so the current check for

Re: [PATCH] drm: Make the decision to keep vblank irq enabled earlier

2017-03-23 Thread Ville Syrjälä
On Thu, Mar 23, 2017 at 07:51:06AM +, Chris Wilson wrote: > We want to provide the vblank irq shadow for pageflip events as well as > vblank queries. Such events are completed within the vblank interrupt > handler, and so the current check for disabling the irq will disable it > from with the

Re: [PATCH] drm: Make the decision to keep vblank irq enabled earlier

2017-03-23 Thread Chris Wilson
Better subject might be drm: Use vblank irq shadow for entire flip sequence -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm: Make the decision to keep vblank irq enabled earlier

2017-03-23 Thread Chris Wilson
We want to provide the vblank irq shadow for pageflip events as well as vblank queries. Such events are completed within the vblank interrupt handler, and so the current check for disabling the irq will disable it from with the same interrupt as the last pageflip event. If we move the decision on