Re: [PATCH] drm: Print bad EDID notices only once

2024-09-26 Thread Andi Kleen
On Thu, Sep 26, 2024 at 03:51:09PM +0200, Maxime Ripard wrote: > Hi, > > On Thu, Sep 26, 2024 at 06:32:53AM GMT, Andi Kleen wrote: > > I have an old monitor that reports a zero EDID block, which results in a > > warning message. This happens on every screen save cycle, and maybe in > > some other

Re: [PATCH] drm: Print bad EDID notices only once

2024-09-26 Thread Ville Syrjälä
On Thu, Sep 26, 2024 at 04:59:00PM +0300, Jani Nikula wrote: > On Thu, 26 Sep 2024, Andi Kleen wrote: > > I have an old monitor that reports a zero EDID block, which results in a > > warning message. This happens on every screen save cycle, and maybe in > > some other situations, and over time the

Re: [PATCH] drm: Print bad EDID notices only once

2024-09-26 Thread Jani Nikula
On Thu, 26 Sep 2024, Andi Kleen wrote: > I have an old monitor that reports a zero EDID block, which results in a > warning message. This happens on every screen save cycle, and maybe in > some other situations, and over time the whole kernel log gets filled > with these redundant messages. Printi

Re: [PATCH] drm: Print bad EDID notices only once

2024-09-26 Thread Andi Kleen
> It may be a good opportunity to switch these over to drm_notice_once() > instead. I looked at it, but the callers to several levels don't have the drm pointer that would be needed for that. It would require changing them, and then all the drivers which call into the generic EDID code. And even t

Re: [PATCH] drm: Print bad EDID notices only once

2024-09-26 Thread Maxime Ripard
Hi, On Thu, Sep 26, 2024 at 06:32:53AM GMT, Andi Kleen wrote: > I have an old monitor that reports a zero EDID block, which results in a > warning message. This happens on every screen save cycle, and maybe in > some other situations, and over time the whole kernel log gets filled > with these red

Re: [PATCH] drm: Print bad EDID notices only once

2024-09-26 Thread Hamza Mahfooz
On 9/26/24 09:32, Andi Kleen wrote: I have an old monitor that reports a zero EDID block, which results in a warning message. This happens on every screen save cycle, and maybe in some other situations, and over time the whole kernel log gets filled with these redundant messages. Printing it only

[PATCH] drm: Print bad EDID notices only once

2024-09-26 Thread Andi Kleen
I have an old monitor that reports a zero EDID block, which results in a warning message. This happens on every screen save cycle, and maybe in some other situations, and over time the whole kernel log gets filled with these redundant messages. Printing it only once should be sufficient. Mark all