[PATCH] drm: bridge: ldb: add support for using channel 1 only

2023-04-04 Thread Luca Ceresoli
The LDB driver currently checks whether dual mode is used, otherwise it assumes only channel 0 is in use. Add support for using only channel 1. In device tree terms, this means linking port 2 only. Doing this cleanly requires changing the logic of the probe functions from this: 1. use of_graph_g

Re: [PATCH] drm: bridge: ldb: add support for using channel 1 only

2023-04-04 Thread Marek Vasut
On 4/4/23 09:37, Luca Ceresoli wrote: [...] @@ -177,28 +183,25 @@ static void fsl_ldb_atomic_enable(struct drm_bridge *bridge, clk_prepare_enable(fsl_ldb->clk); /* Program LDB_CTRL */ - reg = LDB_CTRL_CH0_ENABLE; - - if (fsl_ldb->lvds_dual_link) - reg |

Re: [PATCH] drm: bridge: ldb: add support for using channel 1 only

2023-04-05 Thread Luca Ceresoli
Hi Marek, thanks for the quick and detailed review! On Wed, 5 Apr 2023 05:28:16 +0200 Marek Vasut wrote: > On 4/4/23 09:37, Luca Ceresoli wrote: > > [...] > > > @@ -177,28 +183,25 @@ static void fsl_ldb_atomic_enable(struct drm_bridge > > *bridge, > > clk_prepare_enable(fsl_ldb->clk); >

Re: [PATCH] drm: bridge: ldb: add support for using channel 1 only

2023-04-05 Thread Marek Vasut
On 4/5/23 09:30, Luca Ceresoli wrote: [...] @@ -311,10 +314,23 @@ static int fsl_ldb_probe(struct platform_device *pdev) if (IS_ERR(fsl_ldb->regmap)) return PTR_ERR(fsl_ldb->regmap); - /* Locate the panel DT node. */ - panel_node = of_graph_get_remote_node(dev