Re: [PATCH] drm: rework delayed connector cleanup in connector_iter

2017-12-13 Thread Daniel Vetter
On Wed, Dec 13, 2017 at 02:35:16PM +0100, Daniel Vetter wrote: > On Wed, Dec 13, 2017 at 01:05:49PM +, Chris Wilson wrote: > > Quoting Daniel Vetter (2017-12-13 12:49:36) > > > diff --git a/drivers/gpu/drm/drm_mode_config.c > > > b/drivers/gpu/drm/drm_mode_config.c > > > index 6ffe952142e6..76

Re: [PATCH] drm: rework delayed connector cleanup in connector_iter

2017-12-13 Thread Daniel Vetter
On Wed, Dec 13, 2017 at 01:05:49PM +, Chris Wilson wrote: > Quoting Daniel Vetter (2017-12-13 12:49:36) > > PROBE_DEFER also uses system_wq to reprobe drivers, which means when > > that again fails, and we try to flush the overall system_wq (to get > > all the delayed connectore cleanup work_st

Re: [PATCH] drm: rework delayed connector cleanup in connector_iter

2017-12-13 Thread Chris Wilson
Quoting Daniel Vetter (2017-12-13 12:49:36) > PROBE_DEFER also uses system_wq to reprobe drivers, which means when > that again fails, and we try to flush the overall system_wq (to get > all the delayed connectore cleanup work_struct completed), we > deadlock. > > Fix this by using just a single c

Re: [PATCH] drm: rework delayed connector cleanup in connector_iter

2017-12-13 Thread Marek Szyprowski
Hi Daniel, On 2017-12-13 13:49, Daniel Vetter wrote: PROBE_DEFER also uses system_wq to reprobe drivers, which means when that again fails, and we try to flush the overall system_wq (to get all the delayed connectore cleanup work_struct completed), we deadlock. Fix this by using just a single c

[PATCH] drm: rework delayed connector cleanup in connector_iter

2017-12-13 Thread Daniel Vetter
PROBE_DEFER also uses system_wq to reprobe drivers, which means when that again fails, and we try to flush the overall system_wq (to get all the delayed connectore cleanup work_struct completed), we deadlock. Fix this by using just a single cleanup work, so that we can only flush that one and don'

Re: [PATCH] drm: rework delayed connector cleanup in connector_iter

2017-12-13 Thread Marek Szyprowski
Hi Daniel, On 2017-12-13 11:45, Daniel Vetter wrote: PROBE_DEFER also uses system_wq to reprobe drivers, which means when that again fails, and we try to flush the overall system_wq (to get all the delayed connectore cleanup work_struct completed), we deadlock. Fix this by using just a single c

Re: [PATCH] drm: rework delayed connector cleanup in connector_iter

2017-12-13 Thread Chris Wilson
Quoting Daniel Vetter (2017-12-13 10:45:53) > PROBE_DEFER also uses system_wq to reprobe drivers, which means when > that again fails, and we try to flush the overall system_wq (to get > all the delayed connectore cleanup work_struct completed), we > deadlock. > > Fix this by using just a single c

[PATCH] drm: rework delayed connector cleanup in connector_iter

2017-12-13 Thread Daniel Vetter
PROBE_DEFER also uses system_wq to reprobe drivers, which means when that again fails, and we try to flush the overall system_wq (to get all the delayed connectore cleanup work_struct completed), we deadlock. Fix this by using just a single cleanup work, so that we can only flush that one and don'