Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2023-03-01 Thread Alexander Potapenko
> > I'd like to avoid touching per-arch asm/string.h files if possible. > > Can't we do like below (i.e. keep asm implementations as-is, but > automatically redirect to __msan_memset()) ? If yes, we could move all > __msan_*() redirection from per-arch asm/string.h files to the common >

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2023-01-06 Thread Tetsuo Handa
On 2023/01/05 22:22, Daniel Vetter wrote: > Oh I was more asking about the fbdev patch. This here sounds a lot more > something that needs to be discussed with kmsan people, that's definitely > not my area. > -Daniel Commit a6a00d7e8ffd ("fbcon: Use kzalloc() in fbcon_prepare_logo()") was

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2023-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 10:17:24PM +0900, Tetsuo Handa wrote: > On 2023/01/05 20:54, Daniel Vetter wrote: > >>> . Plain memset() in arch/x86/include/asm/string_64.h is redirected to > >>> __msan_memset() > >>> but memsetXX() are not redirected to __msan_memsetXX(). That is, memory > >>>

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2023-01-05 Thread Tetsuo Handa
On 2023/01/05 20:54, Daniel Vetter wrote: >>> . Plain memset() in arch/x86/include/asm/string_64.h is redirected to >>> __msan_memset() >>> but memsetXX() are not redirected to __msan_memsetXX(). That is, memory >>> initialization >>> via memsetXX() results in KMSAN's shadow memory being not

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2023-01-05 Thread Daniel Vetter
On Fri, Dec 16, 2022 at 04:52:14PM +0100, Alexander Potapenko wrote: > On Fri, Dec 16, 2022 at 3:03 PM Tetsuo Handa > wrote: > > > > On 2022/12/15 18:36, Geert Uytterhoeven wrote: > > > The next line is: > > > > > > scr_memsetw(save, erase, array3_size(logo_lines, new_cols, 2)); > > > > >

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2022-12-16 Thread Alexander Potapenko
On Fri, Dec 16, 2022 at 3:03 PM Tetsuo Handa wrote: > > On 2022/12/15 18:36, Geert Uytterhoeven wrote: > > The next line is: > > > > scr_memsetw(save, erase, array3_size(logo_lines, new_cols, 2)); > > > > So how can this turn out to be uninitialized later below? > > > >

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2022-12-16 Thread Tetsuo Handa
On 2022/12/15 18:36, Geert Uytterhoeven wrote: > The next line is: > > scr_memsetw(save, erase, array3_size(logo_lines, new_cols, 2)); > > So how can this turn out to be uninitialized later below? > > scr_memcpyw(q, save, array3_size(logo_lines, new_cols, 2)); > > What am I

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2022-12-15 Thread Geert Uytterhoeven
Hi Handa-san, On Thu, Nov 17, 2022 at 4:32 PM Tetsuo Handa wrote: > A kernel built with syzbot's config file reported that > > scr_memcpyw(q, save, array3_size(logo_lines, new_cols, 2)) > > causes uninitialized "save" to be copied. > Signed-off-by: Tetsuo Handa Thanks for your patch, which

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2022-11-17 Thread Daniel Vetter
On Fri, Nov 18, 2022 at 12:27:58AM +0900, Tetsuo Handa wrote: > A kernel built with syzbot's config file reported that > > scr_memcpyw(q, save, array3_size(logo_lines, new_cols, 2)) > > causes uninitialized "save" to be copied. > > -- > [drm] Initialized vgem 1.0.0 20120112 for

[PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2022-11-17 Thread Tetsuo Handa
A kernel built with syzbot's config file reported that scr_memcpyw(q, save, array3_size(logo_lines, new_cols, 2)) causes uninitialized "save" to be copied. -- [drm] Initialized vgem 1.0.0 20120112 for vgem on minor 0 [drm] Initialized vkms 1.0.0 20180514 for vkms on minor 1