[PATCH] fbcon: fix race condition between console lock and cursor timer

2012-08-22 Thread Dave Airlie
On Tue, Aug 21, 2012 at 7:15 PM, Alan Cox wrote: >> So after much tracing with direct netconsole writes (printks >> under console_lock not so useful), I think I found the race. > > Direct netconsole write would be a useful patch to have mainline I think > 8) Well I used a one line wrapper around

Re: [PATCH] fbcon: fix race condition between console lock and cursor timer

2012-08-21 Thread Josh Boyer
On Tue, Aug 21, 2012 at 2:40 AM, Dave Airlie wrote: > So we've had a fair few reports of fbcon handover breakage between > efi/vesafb and i915 surface recently, so I dedicated a couple of > days to finding the problem. > > Essentially the last thing we saw was the conflicting framebuffer > message

Re: [PATCH] fbcon: fix race condition between console lock and cursor timer

2012-08-21 Thread Dave Airlie
On Tue, Aug 21, 2012 at 7:15 PM, Alan Cox wrote: >> So after much tracing with direct netconsole writes (printks >> under console_lock not so useful), I think I found the race. > > Direct netconsole write would be a useful patch to have mainline I think > 8) Well I used a one line wrapper around

[PATCH] fbcon: fix race condition between console lock and cursor timer

2012-08-21 Thread Dave Airlie
So we've had a fair few reports of fbcon handover breakage between efi/vesafb and i915 surface recently, so I dedicated a couple of days to finding the problem. Essentially the last thing we saw was the conflicting framebuffer message and that was all. So after much tracing with direct netconsole

[PATCH] fbcon: fix race condition between console lock and cursor timer

2012-08-21 Thread Peter Zijlstra
On Tue, 2012-08-21 at 10:15 +0100, Alan Cox wrote: > > So after much tracing with direct netconsole writes (printks > > under console_lock not so useful), I think I found the race. > > Direct netconsole write would be a useful patch to have mainline I think > 8) could we make that use the earlyp

[PATCH] fbcon: fix race condition between console lock and cursor timer

2012-08-21 Thread Peter Zijlstra
On Tue, 2012-08-21 at 16:40 +1000, Dave Airlie wrote: > So after much tracing with direct netconsole writes (printks > under console_lock not so useful) I always use earlyprintk on serial.. -- Live Security Virtual Conf

[PATCH] fbcon: fix race condition between console lock and cursor timer

2012-08-21 Thread Alan Cox
> So after much tracing with direct netconsole writes (printks > under console_lock not so useful), I think I found the race. Direct netconsole write would be a useful patch to have mainline I think 8) > Hopefully this fixes the problem for anyone seeing vesafb->kms > driver handoff. Not really

[PATCH] fbcon: fix race condition between console lock and cursor timer

2012-08-21 Thread Josh Boyer
On Tue, Aug 21, 2012 at 2:40 AM, Dave Airlie wrote: > So we've had a fair few reports of fbcon handover breakage between > efi/vesafb and i915 surface recently, so I dedicated a couple of > days to finding the problem. > > Essentially the last thing we saw was the conflicting framebuffer > message

Re: [PATCH] fbcon: fix race condition between console lock and cursor timer

2012-08-21 Thread Peter Zijlstra
On Tue, 2012-08-21 at 16:40 +1000, Dave Airlie wrote: > So after much tracing with direct netconsole writes (printks > under console_lock not so useful) I always use earlyprintk on serial.. -- Live Security Virtual Conf

Re: [PATCH] fbcon: fix race condition between console lock and cursor timer

2012-08-21 Thread Peter Zijlstra
On Tue, 2012-08-21 at 10:15 +0100, Alan Cox wrote: > > So after much tracing with direct netconsole writes (printks > > under console_lock not so useful), I think I found the race. > > Direct netconsole write would be a useful patch to have mainline I think > 8) could we make that use the earlyp

Re: [PATCH] fbcon: fix race condition between console lock and cursor timer

2012-08-21 Thread Alan Cox
> So after much tracing with direct netconsole writes (printks > under console_lock not so useful), I think I found the race. Direct netconsole write would be a useful patch to have mainline I think 8) > Hopefully this fixes the problem for anyone seeing vesafb->kms > driver handoff. Not really

[PATCH] fbcon: fix race condition between console lock and cursor timer

2012-08-21 Thread Dave Airlie
So we've had a fair few reports of fbcon handover breakage between efi/vesafb and i915 surface recently, so I dedicated a couple of days to finding the problem. Essentially the last thing we saw was the conflicting framebuffer message and that was all. So after much tracing with direct netconsole