Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-07 Thread Hang Zhang
On Fri, Jan 6, 2023 at 5:46 PM Daniel Vetter wrote: > > On Fri, Jan 06, 2023 at 05:12:57PM -0500, Hang Zhang wrote: > > On Fri, Jan 6, 2023 at 4:19 PM Daniel Vetter wrote: > > > On Fri, Jan 06, 2023 at 03:25:14PM -0500, Hang Zhang wrote: > > > > On Fri, Jan 6, 2023 at 3:05 PM Daniel Vetter

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-07 Thread Hang Zhang
On Fri, Jan 6, 2023 at 3:05 PM Daniel Vetter wrote: > > On Fri, Jan 06, 2023 at 02:58:27PM -0500, Hang Zhang wrote: > > On Fri, Jan 6, 2023 at 1:59 PM Daniel Vetter wrote: > > > > > > On Thu, Jan 05, 2023 at 01:38:54PM -0500, Hang Zhang wrote: > > > > On Thu, Jan 5, 2023 at 5:25 AM Daniel Vetter

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-07 Thread Hang Zhang
On Fri, Jan 6, 2023 at 1:59 PM Daniel Vetter wrote: > > On Thu, Jan 05, 2023 at 01:38:54PM -0500, Hang Zhang wrote: > > On Thu, Jan 5, 2023 at 5:25 AM Daniel Vetter wrote: > > > > > > On Thu, 5 Jan 2023 at 11:21, Daniel Vetter wrote: > > > > > > > > Hi Helge > > > > > > > > On Mon, 2 Jan 2023

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-07 Thread Hang Zhang
On Fri, Jan 6, 2023 at 4:19 PM Daniel Vetter wrote: > > On Fri, Jan 06, 2023 at 03:25:14PM -0500, Hang Zhang wrote: > > On Fri, Jan 6, 2023 at 3:05 PM Daniel Vetter wrote: > > > On Fri, Jan 06, 2023 at 02:58:27PM -0500, Hang Zhang wrote: > > > > On Fri, Jan 6, 2023 at 1:59 PM Daniel Vetter

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-06 Thread Daniel Vetter
On Fri, Jan 06, 2023 at 05:12:57PM -0500, Hang Zhang wrote: > On Fri, Jan 6, 2023 at 4:19 PM Daniel Vetter wrote: > > On Fri, Jan 06, 2023 at 03:25:14PM -0500, Hang Zhang wrote: > > > On Fri, Jan 6, 2023 at 3:05 PM Daniel Vetter wrote: > > > > On Fri, Jan 06, 2023 at 02:58:27PM -0500, Hang Zhang

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-06 Thread Daniel Vetter
On Fri, Jan 06, 2023 at 03:25:14PM -0500, Hang Zhang wrote: > On Fri, Jan 6, 2023 at 3:05 PM Daniel Vetter wrote: > > On Fri, Jan 06, 2023 at 02:58:27PM -0500, Hang Zhang wrote: > > > On Fri, Jan 6, 2023 at 1:59 PM Daniel Vetter wrote: > > > BTW, if this is worthed a fix and the performance of

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-06 Thread Daniel Vetter
On Fri, Jan 06, 2023 at 02:58:27PM -0500, Hang Zhang wrote: > On Fri, Jan 6, 2023 at 1:59 PM Daniel Vetter wrote: > > > > On Thu, Jan 05, 2023 at 01:38:54PM -0500, Hang Zhang wrote: > > > On Thu, Jan 5, 2023 at 5:25 AM Daniel Vetter wrote: > > > > > > > > On Thu, 5 Jan 2023 at 11:21, Daniel

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-06 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 01:38:54PM -0500, Hang Zhang wrote: > On Thu, Jan 5, 2023 at 5:25 AM Daniel Vetter wrote: > > > > On Thu, 5 Jan 2023 at 11:21, Daniel Vetter wrote: > > > > > > Hi Helge > > > > > > On Mon, 2 Jan 2023 at 16:28, Helge Deller wrote: > > > > > > > > On 12/30/22 07:35, Hang

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-06 Thread Hang Zhang
On Thu, Jan 5, 2023 at 5:25 AM Daniel Vetter wrote: > > On Thu, 5 Jan 2023 at 11:21, Daniel Vetter wrote: > > > > Hi Helge > > > > On Mon, 2 Jan 2023 at 16:28, Helge Deller wrote: > > > > > > On 12/30/22 07:35, Hang Zhang wrote: > > > > In do_fb_ioctl(), user specified "fb_info" can be freed in

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-05 Thread Daniel Vetter
On Thu, 5 Jan 2023 at 11:21, Daniel Vetter wrote: > > Hi Helge > > On Mon, 2 Jan 2023 at 16:28, Helge Deller wrote: > > > > On 12/30/22 07:35, Hang Zhang wrote: > > > In do_fb_ioctl(), user specified "fb_info" can be freed in the callee > > > fbcon_get_con2fb_map_ioctl() -> set_con2fb_map() -> >

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-05 Thread Daniel Vetter
Hi Helge On Mon, 2 Jan 2023 at 16:28, Helge Deller wrote: > > On 12/30/22 07:35, Hang Zhang wrote: > > In do_fb_ioctl(), user specified "fb_info" can be freed in the callee > > fbcon_get_con2fb_map_ioctl() -> set_con2fb_map() -> > > con2fb_release_oldinfo(), this free operation is protected by >

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-02 Thread Helge Deller
On 12/30/22 07:35, Hang Zhang wrote: In do_fb_ioctl(), user specified "fb_info" can be freed in the callee fbcon_get_con2fb_map_ioctl() -> set_con2fb_map() -> con2fb_release_oldinfo(), this free operation is protected by console_lock() in fbcon_set_con2fb_map_ioctl(), it also results in the

[PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2022-12-31 Thread Hang Zhang
In do_fb_ioctl(), user specified "fb_info" can be freed in the callee fbcon_get_con2fb_map_ioctl() -> set_con2fb_map() -> con2fb_release_oldinfo(), this free operation is protected by console_lock() in fbcon_set_con2fb_map_ioctl(), it also results in the change of certain states such as