Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

On Fri, 19 Mar 2021 at 19:25, Fabio Estevam wrote: > > On Fri, Mar 19, 2021 at 12:13 PM Fabio Estevam wrote: > > > Thanks for the feedback. > > I will follow the same approach for fixing the suspend/resume path then. > > > > Let me test it and then I will re-submit Dmitry's patch and the one > >

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

On Fri, Mar 19, 2021 at 12:13 PM Fabio Estevam wrote: > Thanks for the feedback. > I will follow the same approach for fixing the suspend/resume path then. > > Let me test it and then I will re-submit Dmitry's patch and the one > for suspend/resume as part of a patch series. This approach works

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

On Fri, Mar 19, 2021 at 8:13 AM Fabio Estevam wrote: > > Hi Rob, > > On Fri, Mar 19, 2021 at 11:44 AM Rob Clark wrote: > > > I think that might not help if something fails to probe due to (for > > example) a missing dependency, so !priv->kms is probably a better > > check to cover both cases.

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

Hi Rob, On Fri, Mar 19, 2021 at 11:44 AM Rob Clark wrote: > I think that might not help if something fails to probe due to (for > example) a missing dependency, so !priv->kms is probably a better > check to cover both cases. But the 2nd patch makes a good point, that > the suspend/resume path

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

On Fri, Mar 19, 2021 at 5:09 AM Fabio Estevam wrote: > > Hi Dmitry, > > On Mon, Mar 1, 2021 at 6:41 PM Dmitry Baryshkov > wrote: > > > diff --git a/drivers/gpu/drm/msm/msm_atomic.c > > b/drivers/gpu/drm/msm/msm_atomic.c > > index 6a326761dc4a..2fd0cf6421ad 100644 > > ---

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

Hi Dmitry, On Mon, Mar 1, 2021 at 6:41 PM Dmitry Baryshkov wrote: > diff --git a/drivers/gpu/drm/msm/msm_atomic.c > b/drivers/gpu/drm/msm/msm_atomic.c > index 6a326761dc4a..2fd0cf6421ad 100644 > --- a/drivers/gpu/drm/msm/msm_atomic.c > +++ b/drivers/gpu/drm/msm/msm_atomic.c > @@ -207,7 +207,12

[PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

if GPU components have failed to bind, shutdown callback would fail with the following backtrace. Add safeguard check to stop that oops from happening and allow the board to reboot. [ 66.617046] Unable to handle kernel NULL pointer dereference at virtual address [ 66.626066]

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

On 17/03/2021 19:25, Rob Clark wrote: On Mon, Mar 1, 2021 at 1:41 PM Dmitry Baryshkov wrote: if GPU components have failed to bind, shutdown callback would fail with the following backtrace. Add safeguard check to stop that oops from happening and allow the board to reboot. [skipped] diff

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

On Mon, Mar 1, 2021 at 1:41 PM Dmitry Baryshkov wrote: > > if GPU components have failed to bind, shutdown callback would fail with > the following backtrace. Add safeguard check to stop that oops from > happening and allow the board to reboot. > > [ 66.617046] Unable to handle kernel NULL

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

On 2021-03-01 13:41, Dmitry Baryshkov wrote: if GPU components have failed to bind, shutdown callback would fail with the following backtrace. Add safeguard check to stop that oops from happening and allow the board to reboot. [ 66.617046] Unable to handle kernel NULL pointer dereference at

[PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

if GPU components have failed to bind, shutdown callback would fail with the following backtrace. Add safeguard check to stop that oops from happening and allow the board to reboot. [ 66.617046] Unable to handle kernel NULL pointer dereference at virtual address [ 66.626066]