Re: [PATCH] qxl: fix framebuffer unpinning

2017-09-25 Thread Gerd Hoffmann
On Fri, 2017-09-22 at 14:37 -0300, Gabriel Krisman Bertazi wrote: > Gerd Hoffmann writes: > > > > I can simply disable X, lightdm or whatever is using it and then > > > rmmod. > > > > Works for me only with CONFIG_FBCON=n, otherwise the fbcon > > framebuffer > > keeps qxl busy.  So is most cases

Re: [PATCH] qxl: fix framebuffer unpinning

2017-09-22 Thread Gabriel Krisman Bertazi
Gerd Hoffmann writes: >> I can simply disable X, lightdm or whatever is using it and then >> rmmod. > > Works for me only with CONFIG_FBCON=n, otherwise the fbcon framebuffer > keeps qxl busy. So is most cases (typical distro kernel build with > FBCON=y) you simply can't rmmod qxl. > > I agree t

Re: [PATCH] qxl: fix framebuffer unpinning

2017-09-21 Thread Gerd Hoffmann
On Fri, 2017-09-22 at 02:03 -0300, Gabriel Krisman Bertazi wrote: > Gerd Hoffmann writes: > > >   Hi, > > > > > > "removing the device"?  qxl can't be hotplugged ... > > > > Or do you mean "rmmod qxl"? > > > > > > rmmod qxl > > > > rmmod: ERROR: Module qxl is in use. > > > > How do you do tha

Re: [PATCH] qxl: fix framebuffer unpinning

2017-09-21 Thread Gabriel Krisman Bertazi
Gerd Hoffmann writes: > Hi, > >> > "removing the device"?  qxl can't be hotplugged ... >> > Or do you mean "rmmod qxl"? >> >> rmmod qxl > > rmmod: ERROR: Module qxl is in use. > > How do you do that? CONFIG_FBCON=n? I can simply disable X, lightdm or whatever is using it and then rmmod. --

Re: [PATCH] qxl: fix framebuffer unpinning

2017-09-20 Thread Gerd Hoffmann
Hi, > > "removing the device"?  qxl can't be hotplugged ... > > Or do you mean "rmmod qxl"? > > rmmod qxl rmmod: ERROR: Module qxl is in use. How do you do that? CONFIG_FBCON=n? cheers, Gerd ___ dri-devel mailing list dri-devel@lists.freedeskto

Re: [PATCH] qxl: fix framebuffer unpinning

2017-09-19 Thread Gabriel Krisman Bertazi
Gerd Hoffmann writes: > On Tue, 2017-09-19 at 11:35 -0300, Gabriel Krisman Bertazi wrote: >> Gerd Hoffmann writes: >> >> > qxl_plane_cleanup_fb() unpins the just activated framebuffer >> > instead of the old one.  Oops.  Fix it. >> > >> > Cc: Gabriel Krisman Bertazi >> > Fixes: 1277eed5fecb88

Re: [PATCH] qxl: fix framebuffer unpinning

2017-09-19 Thread Gerd Hoffmann
On Tue, 2017-09-19 at 11:35 -0300, Gabriel Krisman Bertazi wrote: > Gerd Hoffmann writes: > > > qxl_plane_cleanup_fb() unpins the just activated framebuffer > > instead of the old one.  Oops.  Fix it. > > > > Cc: Gabriel Krisman Bertazi > > Fixes: 1277eed5fecb8830c8cc414ad70c1ef640464bc0 > > Si

Re: [PATCH] qxl: fix framebuffer unpinning

2017-09-19 Thread Gabriel Krisman Bertazi
Gerd Hoffmann writes: > qxl_plane_cleanup_fb() unpins the just activated framebuffer > instead of the old one. Oops. Fix it. > > Cc: Gabriel Krisman Bertazi > Fixes: 1277eed5fecb8830c8cc414ad70c1ef640464bc0 > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/qxl/qxl_display.c | 7 ---

[PATCH] qxl: fix framebuffer unpinning

2017-09-18 Thread Gerd Hoffmann
qxl_plane_cleanup_fb() unpins the just activated framebuffer instead of the old one. Oops. Fix it. Cc: Gabriel Krisman Bertazi Fixes: 1277eed5fecb8830c8cc414ad70c1ef640464bc0 Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.c | 7 --- 1 file changed, 4 insertions(+), 3 del