Re: [PATCH] video/aperture: fix typos

2023-05-12 Thread Pavel Machek
Hi! > > Am 04.04.23 um 06:01 schrieb Sui Jingfeng: > >> EFI FB, VESA FB or VGA FB etc are belong to firmware based framebuffer > >> driver. > > > ... > I fixed that before applying, also removed the "are" in the sentence > above, since it sounded off and repharsed subject line as "Fix typos

Re: [PATCH] video/aperture: fix typos

2023-04-05 Thread Sui Jingfeng
On 2023/4/5 17:55, Sui Jingfeng wrote: Hi, thanks you for the time and effort  for reviewing. On 2023/4/4 19:03, Javier Martinez Canillas wrote: Javier Martinez Canillas writes: [...]    /*     * Remove the device from the device hierarchy. This is the right thing - * to do

Re: [PATCH] video/aperture: fix typos

2023-04-05 Thread Sui Jingfeng
Hi, thanks you for the time and effort  for reviewing. On 2023/4/4 19:03, Javier Martinez Canillas wrote: Javier Martinez Canillas writes: [...] /* * Remove the device from the device hierarchy. This is the right thing -* to do for firmware-based DRM drivers, such

Re: [PATCH] video/aperture: fix typos

2023-04-04 Thread Thomas Zimmermann
Hi Am 04.04.23 um 12:55 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Sorry, I just applied this patch and didn't see your email before... Hi Am 04.04.23 um 06:01 schrieb Sui Jingfeng: EFI FB, VESA FB or VGA FB etc are belong to firmware based framebuffer

Re: [PATCH] video/aperture: fix typos

2023-04-04 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: [...] >>> /* >>> * Remove the device from the device hierarchy. This is the right thing >>> -* to do for firmware-based DRM drivers, such as EFI, VESA or VGA. After >>> +* to do for firmware-based fb drivers, such as EFI, VESA or VGA. After >>

Re: [PATCH] video/aperture: fix typos

2023-04-04 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, Sorry, I just applied this patch and didn't see your email before... > Hi > > Am 04.04.23 um 06:01 schrieb Sui Jingfeng: >> EFI FB, VESA FB or VGA FB etc are belong to firmware based framebuffer >> driver. > > No whitespaces at the beginning of the

Re: [PATCH] video/aperture: fix typos

2023-04-04 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Sui Jingfeng writes: > >> EFI FB, VESA FB or VGA FB etc are belong to firmware based framebuffer >> driver. >> >> Signed-off-by: Sui Jingfeng >> --- > > Reviewed-by: Javier Martinez Canillas > Pushed to drm-misc (drm-misc-next). Thanks! -- Best regards,

Re: [PATCH] video/aperture: fix typos

2023-04-04 Thread Thomas Zimmermann
Hi Am 04.04.23 um 06:01 schrieb Sui Jingfeng: EFI FB, VESA FB or VGA FB etc are belong to firmware based framebuffer driver. No whitespaces at the beginning of the lines. Signed-off-by: Sui Jingfeng --- drivers/video/aperture.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH] video/aperture: fix typos

2023-04-04 Thread Javier Martinez Canillas
Sui Jingfeng writes: > EFI FB, VESA FB or VGA FB etc are belong to firmware based framebuffer > driver. > > Signed-off-by: Sui Jingfeng > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

[PATCH] video/aperture: fix typos

2023-04-03 Thread Sui Jingfeng
EFI FB, VESA FB or VGA FB etc are belong to firmware based framebuffer driver. Signed-off-by: Sui Jingfeng --- drivers/video/aperture.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/aperture.c b/drivers/video/aperture.c index