Re: [PATCH] video/fbdev: refactor video= cmdline parsing

2019-02-08 Thread Bartlomiej Zolnierkiewicz
On 01/23/2019 12:12 PM, Jani Nikula wrote: > On Wed, 23 Jan 2019, Daniel Vetter wrote: >> On Wed, Jan 23, 2019 at 11:38:17AM +0200, Jani Nikula wrote: >>> Make the video_setup() function slightly easier to read by removing the >>> repeated checks for !global. Remove the misleading return value

Re: [PATCH] video/fbdev: refactor video= cmdline parsing

2019-01-23 Thread Jani Nikula
On Wed, 23 Jan 2019, Daniel Vetter wrote: > On Wed, Jan 23, 2019 at 11:38:17AM +0200, Jani Nikula wrote: >> Make the video_setup() function slightly easier to read by removing the >> repeated checks for !global. Remove the misleading return value comment >> while at it. >> >> I'm slightly

Re: [PATCH] video/fbdev: refactor video= cmdline parsing

2019-01-23 Thread Daniel Vetter
On Wed, Jan 23, 2019 at 11:38:17AM +0200, Jani Nikula wrote: > Make the video_setup() function slightly easier to read by removing the > repeated checks for !global. Remove the misleading return value comment > while at it. > > I'm slightly hesitant to change any of this, but here goes anyway,

[PATCH] video/fbdev: refactor video= cmdline parsing

2019-01-23 Thread Jani Nikula
Make the video_setup() function slightly easier to read by removing the repeated checks for !global. Remove the misleading return value comment while at it. I'm slightly hesitant to change any of this, but here goes anyway, with hopes that the next person to have to look at this has it a wee bit