Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-07-05 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:01 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/video/fbdev/s3c-fb.c: In function ‘s3c_fb_blank’: >

Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-06-25 Thread Kees Cook
On Tue, Jun 25, 2019 at 10:49:01AM -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 10:31 -0700, Kees Cook wrote: > > On Tue, Jun 25, 2019 at 09:52:23AM -0700, Joe Perches wrote: > > > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > > > > In preparation to enabling

Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-06-25 Thread Joe Perches
On Tue, 2019-06-25 at 10:31 -0700, Kees Cook wrote: > On Tue, Jun 25, 2019 at 09:52:23AM -0700, Joe Perches wrote: > > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > > cases where we are expecting to fall

Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-06-25 Thread Joe Perches
On Tue, 2019-06-25 at 12:06 -0500, Gustavo A. R. Silva wrote: > > On 6/25/19 11:52 AM, Joe Perches wrote: > > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > > cases where we are expecting to fall through. > >

Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-06-25 Thread Kees Cook
On Tue, Jun 25, 2019 at 09:52:23AM -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > cases where we are expecting to fall through. > [] > > This patch is part of the ongoing efforts to

Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-06-25 Thread Gustavo A. R. Silva
On 6/25/19 11:52 AM, Joe Perches wrote: > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. > [] >> This patch is part of the ongoing efforts to enable >>

Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-06-25 Thread Joe Perches
On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. [] > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. Just enable the thing already. If you

[PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-06-25 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/video/fbdev/s3c-fb.c: In function ‘s3c_fb_blank’: drivers/video/fbdev/s3c-fb.c:811:16: warning: this statement may fall through