Re: [PATCH 0/5] accel/qaic: Improve bounds checking in encode/decode

2023-06-22 Thread Dan Carpenter
On Wed, Jun 21, 2023 at 08:53:41PM -0600, Jeffrey Hugo wrote: > On 6/21/2023 1:21 AM, Dan Carpenter wrote: > > (I think this is the first cover letter I have ever written). > > > > These patches are based on review and not from testing. > > Thank you for your review. I look forward to reading yo

Re: [PATCH 0/5] accel/qaic: Improve bounds checking in encode/decode

2023-06-21 Thread Jeffrey Hugo
On 6/21/2023 1:21 AM, Dan Carpenter wrote: (I think this is the first cover letter I have ever written). These patches are based on review and not from testing. Thank you for your review. I look forward to reading your patches and learning from them. Did you use any kind of tooling? If th

[PATCH 0/5] accel/qaic: Improve bounds checking in encode/decode

2023-06-21 Thread Dan Carpenter
(I think this is the first cover letter I have ever written). These patches are based on review and not from testing. I found it quite complicated to track the buffer sizes. What happens is the qaic_manage() gets a buffer user_msg->data[] which has user_msg->len bytes. The qaic_manage() calls q