Re: [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

2022-11-01 Thread Yi Liu
On 2022/10/26 02:17, Jason Gunthorpe wrote: This error unwind is getting complicated. Move all the code into two pair'd function. The functions should be called when the open_count == 1 after incrementing/before decrementing. Signed-off-by: Jason Gunthorpe --- drivers/vfio/vfio_main.c | 95

Re: [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

2022-11-01 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 07:33:30AM +, Tian, Kevin wrote: > > + /* > > +* Here we pass the KVM pointer with the group under the read lock. > > Now the read lock is replaced by mutex. Let's correct it when moving this > piece of code. Done, thanks Jason

RE: [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

2022-11-01 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:17 AM > > This error unwind is getting complicated. Move all the code into two > pair'd function. The functions should be called when the open_count == 1 > after incrementing/before decrementing. > > Signed-off-by: Jason Gunthorpe

[PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

2022-10-25 Thread Jason Gunthorpe
This error unwind is getting complicated. Move all the code into two pair'd function. The functions should be called when the open_count == 1 after incrementing/before decrementing. Signed-off-by: Jason Gunthorpe --- drivers/vfio/vfio_main.c | 95 ++-- 1 file