Re: [PATCH 01/11] drm/sched: Split drm_sched_job_init

2021-06-24 Thread Daniel Vetter
On Thu, Jun 24, 2021 at 7:39 PM Christian König wrote: > > > > Am 24.06.21 um 19:37 schrieb Daniel Vetter: > > On Thu, Jun 24, 2021 at 7:30 PM Christian König > > wrote: > >> Am 24.06.21 um 16:00 schrieb Daniel Vetter: > >>> This is a very confusingly named function, because not just does it >

Re: [PATCH 01/11] drm/sched: Split drm_sched_job_init

2021-06-24 Thread Christian König
Am 24.06.21 um 19:37 schrieb Daniel Vetter: On Thu, Jun 24, 2021 at 7:30 PM Christian König wrote: Am 24.06.21 um 16:00 schrieb Daniel Vetter: This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job

Re: [PATCH 01/11] drm/sched: Split drm_sched_job_init

2021-06-24 Thread Daniel Vetter
On Thu, Jun 24, 2021 at 7:30 PM Christian König wrote: > > Am 24.06.21 um 16:00 schrieb Daniel Vetter: > > This is a very confusingly named function, because not just does it > > init an object, it arms it and provides a point of no return for > > pushing a job into the scheduler. It would be

Re: [PATCH 01/11] drm/sched: Split drm_sched_job_init

2021-06-24 Thread Christian König
Am 24.06.21 um 16:00 schrieb Daniel Vetter: This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into the scheduler. It would be nice if that's a bit clearer in the interface. We originally had that

Re: [PATCH 01/11] drm/sched: Split drm_sched_job_init

2021-06-24 Thread Steven Price
On 24/06/2021 15:00, Daniel Vetter wrote: > This is a very confusingly named function, because not just does it > init an object, it arms it and provides a point of no return for > pushing a job into the scheduler. It would be nice if that's a bit > clearer in the interface. > > But the real

[PATCH 01/11] drm/sched: Split drm_sched_job_init

2021-06-24 Thread Daniel Vetter
This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into the scheduler. It would be nice if that's a bit clearer in the interface. But the real reason is that I want to push the dependency tracking