Re: [PATCH 03/10] drm/msm/gpu: Capture the state of the GPU

2018-05-22 Thread Sharat Masetty
A few nits On 4/18/2018 4:14 AM, Jordan Crouse wrote: Add the infrastructure to capture the state current state of the remove extra state GPU and store it in memory. This is useful for storing the state of a hung GPU so it can be dumped later. For now grab the same basic ringbuffer

[PATCH 03/10] drm/msm/gpu: Capture the state of the GPU

2018-04-17 Thread Jordan Crouse
Add the infrastructure to capture the state current state of the GPU and store it in memory. This is useful for storing the state of a hung GPU so it can be dumped later. For now grab the same basic ringbuffer information and registers that are provided by the debugfs 'gpu' node but obviously

Re: [PATCH 03/10] drm/msm/gpu: Capture the state of the GPU

2018-04-06 Thread Chris Wilson
Quoting Jordan Crouse (2018-04-05 23:00:49) > +struct msm_gpu_state { > + struct timeval time; My recommendation would be to make this a kreffed struct. You already have multiple uncoordinated consumers so managing the lifetime would seem to be a point of concern? -Chris

[PATCH 03/10] drm/msm/gpu: Capture the state of the GPU

2018-04-05 Thread Jordan Crouse
Add the infrastructure to capture the state current state of the GPU and store it in memory. This is useful for storing the state of a hung GPU so it can be dumped later. For now grab the same basic ringbuffer information and registers that are provided by the debugfs 'gpu' node but obviously