Re: [PATCH 03/26] drm/i915/guc: Take engine PM when a context is pinned with GuC submission

2021-10-07 Thread Matthew Brost
On Thu, Oct 07, 2021 at 11:15:51AM -0700, John Harrison wrote: > On 10/7/2021 08:19, Matthew Brost wrote: > > On Wed, Oct 06, 2021 at 08:45:42PM -0700, John Harrison wrote: > > > On 10/4/2021 15:06, Matthew Brost wrote: > > > > Taking a PM reference to prevent intel_gt_wait_for_idle from short > >

Re: [PATCH 03/26] drm/i915/guc: Take engine PM when a context is pinned with GuC submission

2021-10-07 Thread John Harrison
On 10/7/2021 08:19, Matthew Brost wrote: On Wed, Oct 06, 2021 at 08:45:42PM -0700, John Harrison wrote: On 10/4/2021 15:06, Matthew Brost wrote: Taking a PM reference to prevent intel_gt_wait_for_idle from short circuiting while a scheduling of user context could be enabled. I'm not sure what

Re: [PATCH 03/26] drm/i915/guc: Take engine PM when a context is pinned with GuC submission

2021-10-07 Thread Matthew Brost
On Wed, Oct 06, 2021 at 08:45:42PM -0700, John Harrison wrote: > On 10/4/2021 15:06, Matthew Brost wrote: > > Taking a PM reference to prevent intel_gt_wait_for_idle from short > > circuiting while a scheduling of user context could be enabled. > I'm not sure what 'while a scheduling of user contex

Re: [PATCH 03/26] drm/i915/guc: Take engine PM when a context is pinned with GuC submission

2021-10-06 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: Taking a PM reference to prevent intel_gt_wait_for_idle from short circuiting while a scheduling of user context could be enabled. I'm not sure what 'while a scheduling of user context could be enabled' means. John. Returning GT idle when it is not ca

[PATCH 03/26] drm/i915/guc: Take engine PM when a context is pinned with GuC submission

2021-10-04 Thread Matthew Brost
Taking a PM reference to prevent intel_gt_wait_for_idle from short circuiting while a scheduling of user context could be enabled. Returning GT idle when it is not can cause all sorts of issues throughout the stack. v2: (Daniel Vetter) - Add might_lock annotations to pin / unpin function v3: (