Re: [PATCH 04/12] drm: Nuke mode->vrefresh

2020-02-25 Thread Linus Walleij
On Tue, Feb 25, 2020 at 8:27 PM Ville Syrjälä wrote: > OK, so I went ahead a wrote a bit of cocci [1] to find the bad apples. That's impressive :D > Unfortunately it found a lot of strange stuff: I will answer for the weirdness I caused. I have long suspected that a whole bunch of the "simple

Re: [PATCH 04/12] drm: Nuke mode->vrefresh

2020-02-25 Thread Ville Syrjälä
On Tue, Feb 25, 2020 at 05:45:06PM +0200, Ville Syrjälä wrote: > On Tue, Feb 25, 2020 at 04:19:27PM +0100, Andrzej Hajda wrote: > > On 25.02.2020 12:21, Ville Syrjälä wrote: > > > On Mon, Feb 24, 2020 at 03:14:54PM +0100, Andrzej Hajda wrote: > > >> On 19.02.2020 21:35, Ville Syrjala wrote: > > >>>

Re: [PATCH 04/12] drm: Nuke mode->vrefresh

2020-02-25 Thread Ville Syrjälä
On Tue, Feb 25, 2020 at 04:19:27PM +0100, Andrzej Hajda wrote: > On 25.02.2020 12:21, Ville Syrjälä wrote: > > On Mon, Feb 24, 2020 at 03:14:54PM +0100, Andrzej Hajda wrote: > >> On 19.02.2020 21:35, Ville Syrjala wrote: > >>> From: Ville Syrjälä > >>> > >>> Get rid of mode->vrefresh and just calc

Re: [PATCH 04/12] drm: Nuke mode->vrefresh

2020-02-25 Thread Andrzej Hajda
On 25.02.2020 12:21, Ville Syrjälä wrote: > On Mon, Feb 24, 2020 at 03:14:54PM +0100, Andrzej Hajda wrote: >> On 19.02.2020 21:35, Ville Syrjala wrote: >>> From: Ville Syrjälä >>> >>> Get rid of mode->vrefresh and just calculate it on demand. Saves >>> a bit of space and avoids the cached value ge

Re: [PATCH 04/12] drm: Nuke mode->vrefresh

2020-02-25 Thread Ville Syrjälä
On Mon, Feb 24, 2020 at 03:14:54PM +0100, Andrzej Hajda wrote: > On 19.02.2020 21:35, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Get rid of mode->vrefresh and just calculate it on demand. Saves > > a bit of space and avoids the cached value getting out of sync > > with reality. > > > > M

Re: [PATCH 04/12] drm: Nuke mode->vrefresh

2020-02-24 Thread Andrzej Hajda
On 19.02.2020 21:35, Ville Syrjala wrote: > From: Ville Syrjälä > > Get rid of mode->vrefresh and just calculate it on demand. Saves > a bit of space and avoids the cached value getting out of sync > with reality. > > Mostly done with cocci, with the following manual fixups: > - Remove the now emp

Re: [PATCH 04/12] drm: Nuke mode->vrefresh

2020-02-24 Thread Ville Syrjälä
On Sat, Feb 22, 2020 at 01:32:40PM +0100, Sam Ravnborg wrote: > Hi Ville. > > Nice patch - and diffstat looks good: > > 63 files changed, 217 insertions(+), 392 deletions(-) > > There is an item in the Documentation/gpu/todo.rst that > describes this. > Could you drop this from todo.rst in this

Re: [PATCH 04/12] drm: Nuke mode->vrefresh

2020-02-22 Thread Sam Ravnborg
Hi Ville. Nice patch - and diffstat looks good: > 63 files changed, 217 insertions(+), 392 deletions(-) There is an item in the Documentation/gpu/todo.rst that describes this. Could you drop this from todo.rst in this patch too. > diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/m

Re: [PATCH 04/12] drm: Nuke mode->vrefresh

2020-02-20 Thread Emil Velikov
On Wed, 19 Feb 2020 at 20:36, Ville Syrjala wrote: > > From: Ville Syrjälä > > Get rid of mode->vrefresh and just calculate it on demand. Saves > a bit of space and avoids the cached value getting out of sync > with reality. > > Mostly done with cocci, with the following manual fixups: > - Remove