Re: [PATCH 05/13] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

2023-05-18 Thread Nautiyal, Ankit K
Thanks Ville and Stan for the comments. I agree with the changes in _plane_min_cdclk and intel_pixel_rate_to_cdclk regarding PPC. But I am a little confused for about the pixel clock. Please find my comments inline: On 5/16/2023 3:41 PM, Lisovskiy, Stanislav wrote: On Mon, May 15, 2023 at

Re: [PATCH 05/13] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

2023-05-16 Thread Lisovskiy, Stanislav
On Mon, May 15, 2023 at 05:44:51PM +0300, Ville Syrjälä wrote: > On Fri, May 12, 2023 at 11:54:09AM +0530, Ankit Nautiyal wrote: > > As per Bsepc:49259, Bigjoiner BW check puts restriction on the > > compressed bpp for a given CDCLK, pixelclock in cases where > > Bigjoiner + DSC are used. > > > >

Re: [PATCH 05/13] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

2023-05-15 Thread Ville Syrjälä
On Fri, May 12, 2023 at 11:54:09AM +0530, Ankit Nautiyal wrote: > As per Bsepc:49259, Bigjoiner BW check puts restriction on the > compressed bpp for a given CDCLK, pixelclock in cases where > Bigjoiner + DSC are used. > > Currently compressed bpp is computed first, and it is ensured that > the

[PATCH 05/13] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

2023-05-12 Thread Ankit Nautiyal
As per Bsepc:49259, Bigjoiner BW check puts restriction on the compressed bpp for a given CDCLK, pixelclock in cases where Bigjoiner + DSC are used. Currently compressed bpp is computed first, and it is ensured that the bpp will work at least with the max CDCLK freq. Since the CDCLK is computed