Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-24 Thread Ville Syrjälä
On Fri, Nov 24, 2017 at 02:26:09PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/17/2017 6:19 PM, Ville Syrjälä wrote: > > On Fri, Nov 17, 2017 at 05:50:11PM +0530, Sharma, Shashank wrote: > >> Regards > >> > >> Shashank > >> > >> > >> On 11/17/2017 5:05 PM, Ville Syrjälä wro

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-24 Thread Sharma, Shashank
Regards Shashank On 11/17/2017 6:19 PM, Ville Syrjälä wrote: On Fri, Nov 17, 2017 at 05:50:11PM +0530, Sharma, Shashank wrote: Regards Shashank On 11/17/2017 5:05 PM, Ville Syrjälä wrote: On Fri, Nov 17, 2017 at 08:49:49AM +0530, Sharma, Shashank wrote: Regards Shashank On 11/16/2017

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-17 Thread Ville Syrjälä
On Fri, Nov 17, 2017 at 05:50:11PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/17/2017 5:05 PM, Ville Syrjälä wrote: > > On Fri, Nov 17, 2017 at 08:49:49AM +0530, Sharma, Shashank wrote: > >> Regards > >> > >> Shashank > >> > >> > >> On 11/16/2017 9:53 PM, Ville Syrjälä wro

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-17 Thread Sharma, Shashank
Regards Shashank On 11/17/2017 5:05 PM, Ville Syrjälä wrote: On Fri, Nov 17, 2017 at 08:49:49AM +0530, Sharma, Shashank wrote: Regards Shashank On 11/16/2017 9:53 PM, Ville Syrjälä wrote: On Thu, Nov 16, 2017 at 08:21:44PM +0530, Sharma, Shashank wrote: Regards Shashank On 11/13/2017

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-17 Thread Ville Syrjälä
On Fri, Nov 17, 2017 at 08:49:49AM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/16/2017 9:53 PM, Ville Syrjälä wrote: > > On Thu, Nov 16, 2017 at 08:21:44PM +0530, Sharma, Shashank wrote: > >> Regards > >> > >> Shashank > >> > >> > >> On 11/13/2017 10:34 PM, Ville Syrjala wr

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-16 Thread Sharma, Shashank
Regards Shashank On 11/16/2017 9:53 PM, Ville Syrjälä wrote: On Thu, Nov 16, 2017 at 08:21:44PM +0530, Sharma, Shashank wrote: Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-16 Thread Ville Syrjälä
On Thu, Nov 16, 2017 at 08:21:44PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/13/2017 10:34 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") > > cause us to not send out any VICs in the AVI infofra

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-16 Thread Sharma, Shashank
Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we ne

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-13 Thread Ville Syrjälä
On Mon, Nov 13, 2017 at 06:13:37PM +, Jose Abreu wrote: > Hi Ville, > > On 13-11-2017 17:04, Ville Syrjala wrote: > > > > + if (to_match->picture_aspect_ratio) > > + match_flags |= DRM_MODE_MATCH_ASPECT_RATIO; > > + > > > > Maybe "if (to_match->picture_aspect_ratio != > HDMI_PIC

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-13 Thread Jose Abreu
Hi Ville, On 13-11-2017 17:04, Ville Syrjala wrote: > > + if (to_match->picture_aspect_ratio) > + match_flags |= DRM_MODE_MATCH_ASPECT_RATIO; > + > Maybe "if (to_match->picture_aspect_ratio != HDMI_PICTURE_ASPECT_NONE && to_match->picture_aspect_ratio != HDMI_PICTURE_ASPECT_RESE

[PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-13 Thread Ville Syrjala
From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's handle this by considering the aspect