Re: [PATCH 06/20] lib: Add video format information library

2019-04-23 Thread Paul Kocialkowski
Hi, Le mardi 23 avril 2019 à 13:22 +0200, Thomas Zimmermann a écrit : > Hi > > Am 17.04.19 um 09:54 schrieb Maxime Ripard: > > Move the DRM formats API to turn this into a more generic image formats API > > to be able to leverage it into some other places of the kernel, such as > > v4l2 drivers.

Re: [PATCH 06/20] lib: Add video format information library

2019-04-23 Thread Thomas Zimmermann
Hi Am 17.04.19 um 09:54 schrieb Maxime Ripard: > Move the DRM formats API to turn this into a more generic image formats API > to be able to leverage it into some other places of the kernel, such as > v4l2 drivers. Here's some nitpicking: 'image_format_*' appears slightly vague; it could refer

Re: [PATCH 06/20] lib: Add video format information library

2019-04-17 Thread Paul Kocialkowski
Hi, On Wed, 2019-04-17 at 14:48 +0200, Maxime Ripard wrote: > Hi, > > On Wed, Apr 17, 2019 at 02:34:54PM +0200, Paul Kocialkowski wrote: > > > +struct image_format_info { > > > + union { > > > + /** > > > + * @drm_fmt: > > > + * > > > + * DRM 4CC format

Re: [PATCH 06/20] lib: Add video format information library

2019-04-17 Thread Maxime Ripard
Hi, On Wed, Apr 17, 2019 at 02:34:54PM +0200, Paul Kocialkowski wrote: > > +struct image_format_info { > > + union { > > + /** > > +* @drm_fmt: > > +* > > +* DRM 4CC format identifier (DRM_FORMAT_*) > > +*/ > > + u32 drm_fmt; >

Re: [PATCH 06/20] lib: Add video format information library

2019-04-17 Thread Paul Kocialkowski
Hi, On Wed, 2019-04-17 at 09:54 +0200, Maxime Ripard wrote: > Move the DRM formats API to turn this into a more generic image formats API > to be able to leverage it into some other places of the kernel, such as > v4l2 drivers. See a few comments below. > Signed-off-by: Maxime Ripard > --- >

[PATCH 06/20] lib: Add video format information library

2019-04-17 Thread Maxime Ripard
Move the DRM formats API to turn this into a more generic image formats API to be able to leverage it into some other places of the kernel, such as v4l2 drivers. Signed-off-by: Maxime Ripard --- include/linux/image-formats.h | 387 +- lib/Kconfig | 7 +-

Re: [RFC PATCH 06/20] lib: Add video format information library

2019-03-21 Thread Boris Brezillon
On Thu, 21 Mar 2019 09:20:41 +0100 Maxime Ripard wrote: > Hi Boris, > > On Wed, Mar 20, 2019 at 02:39:44PM +0100, Boris Brezillon wrote: > > On Tue, 19 Mar 2019 22:57:11 +0100 > > Maxime Ripard wrote: > > > > > Move the DRM formats API to turn this into a more generic image formats > > >

Re: [RFC PATCH 06/20] lib: Add video format information library

2019-03-21 Thread Maxime Ripard
Hi Boris, On Wed, Mar 20, 2019 at 02:39:44PM +0100, Boris Brezillon wrote: > On Tue, 19 Mar 2019 22:57:11 +0100 > Maxime Ripard wrote: > > > Move the DRM formats API to turn this into a more generic image formats API > > to be able to leverage it into some other places of the kernel, such as > >

Re: [RFC PATCH 06/20] lib: Add video format information library

2019-03-20 Thread Boris Brezillon
On Tue, 19 Mar 2019 22:57:11 +0100 Maxime Ripard wrote: > Move the DRM formats API to turn this into a more generic image formats API > to be able to leverage it into some other places of the kernel, such as > v4l2 drivers. > > Signed-off-by: Maxime Ripard > --- >

[RFC PATCH 06/20] lib: Add video format information library

2019-03-19 Thread Maxime Ripard
Move the DRM formats API to turn this into a more generic image formats API to be able to leverage it into some other places of the kernel, such as v4l2 drivers. Signed-off-by: Maxime Ripard --- include/linux/image-formats.h | 240 +++- lib/Kconfig | 7 +-