Re: [PATCH 06/27] habanalabs: use memhash_node_export_put() in hl_release_dmabuf()

2023-02-16 Thread Stanislaw Gruszka
On Thu, Feb 16, 2023 at 02:26:50PM +, Tomer Tayar wrote: > > This looks suspicious, I think hnode can be not-NULL here and has > > hnode->vaddr different than searched addr, in case there is > > hash collision and we iterate over hlist where there is no > > searched addr. Not 100% sure about

RE: [PATCH 06/27] habanalabs: use memhash_node_export_put() in hl_release_dmabuf()

2023-02-16 Thread Tomer Tayar
On Thu, Feb 16, 2023 at 13:48 Stanislaw Gruszka wrote: > > The same mutex lock/unlock and counter decrementing in > > hl_release_dmabuf() is already done in the memhash_node_export_put() > > helper function. > > > > Signed-off-by: Tomer Tayar > > Reviewed-by: Oded Gabbay > > Signed-off-by:

Re: [PATCH 06/27] habanalabs: use memhash_node_export_put() in hl_release_dmabuf()

2023-02-16 Thread Stanislaw Gruszka
On Sun, Feb 12, 2023 at 10:44:33PM +0200, Oded Gabbay wrote: > From: Tomer Tayar > > The same mutex lock/unlock and counter decrementing in > hl_release_dmabuf() is already done in the memhash_node_export_put() > helper function. > > Signed-off-by: Tomer Tayar > Reviewed-by: Oded Gabbay >

[PATCH 06/27] habanalabs: use memhash_node_export_put() in hl_release_dmabuf()

2023-02-12 Thread Oded Gabbay
From: Tomer Tayar The same mutex lock/unlock and counter decrementing in hl_release_dmabuf() is already done in the memhash_node_export_put() helper function. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/memory.c | 89