From: Christian Koenig
So we can skip the looking. Also renames sw_int to
ring_int, cause that better matches its purpose.
Signed-off-by: Christian Koenig
---
drivers/gpu/drm/radeon/evergreen.c | 32 -
drivers/gpu/drm/radeon/r100.c | 10 +++---
drivers/gpu/dr
On Fre, 2012-06-01 at 12:44 +0200, Christian K?nig wrote:
> On 01.06.2012 08:30, Michel D?nzer wrote:
> > On Fre, 2012-06-01 at 08:19 +0200, Michel D?nzer wrote:
> >> I think this might introduce a race condition:
> >>
> >> Thread 0 Thread 1
> >>
> >> atomic_inc_return() returns
On 01.06.2012 08:30, Michel D?nzer wrote:
> On Fre, 2012-06-01 at 08:19 +0200, Michel D?nzer wrote:
>> I think this might introduce a race condition:
>>
>> Thread 0 Thread 1
>>
>> atomic_inc_return() returns 1
>> spin_lock_irqsave()
>> atomic_dec_and_test()
>> radeon_irq_set()
>>
On Fre, 2012-06-01 at 08:19 +0200, Michel D?nzer wrote:
>
> I think this might introduce a race condition:
>
> Thread 0 Thread 1
>
> atomic_inc_return() returns 1
> spin_lock_irqsave()
> atomic_dec_and_test()
> radeon_irq_set()
>
> => the interrupt won't be enabled.
Hrmm, I m
On Don, 2012-05-31 at 22:16 +0200, Christian K?nig wrote:
>
> So we can skip the looking.
'locking'
> diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c
> b/drivers/gpu/drm/radeon/radeon_irq_kms.c
> index 73cd0fd..52f85ba 100644
> --- a/drivers/gpu/drm/radeon/radeon_irq_kms.c
> +++ b/driver
From: Christian Koenig
So we can skip the looking. Also renames sw_int to
ring_int, cause that better matches its purpose.
Signed-off-by: Christian Koenig
---
drivers/gpu/drm/radeon/evergreen.c | 32 -
drivers/gpu/drm/radeon/r100.c | 10 +++---
drivers/gpu/dr
On Fre, 2012-06-01 at 12:44 +0200, Christian König wrote:
> On 01.06.2012 08:30, Michel Dänzer wrote:
> > On Fre, 2012-06-01 at 08:19 +0200, Michel Dänzer wrote:
> >> I think this might introduce a race condition:
> >>
> >> Thread 0 Thread 1
> >>
> >> atomic_inc_return() returns
On 01.06.2012 08:30, Michel Dänzer wrote:
On Fre, 2012-06-01 at 08:19 +0200, Michel Dänzer wrote:
I think this might introduce a race condition:
Thread 0 Thread 1
atomic_inc_return() returns 1
spin_lock_irqsave()
atomic_dec_and_test()
radeon_irq_set()
=> the interrupt won't
On Fre, 2012-06-01 at 08:19 +0200, Michel Dänzer wrote:
>
> I think this might introduce a race condition:
>
> Thread 0 Thread 1
>
> atomic_inc_return() returns 1
> spin_lock_irqsave()
> atomic_dec_and_test()
> radeon_irq_set()
>
> => the interrupt won't be enabled.
Hrmm, I m
On Don, 2012-05-31 at 22:16 +0200, Christian König wrote:
>
> So we can skip the looking.
'locking'
> diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c
> b/drivers/gpu/drm/radeon/radeon_irq_kms.c
> index 73cd0fd..52f85ba 100644
> --- a/drivers/gpu/drm/radeon/radeon_irq_kms.c
> +++ b/driver
From: Christian Koenig
So we can skip the looking. Also renames sw_int to
ring_int, cause that better matches its purpose.
Signed-off-by: Christian Koenig
---
drivers/gpu/drm/radeon/evergreen.c | 32 -
drivers/gpu/drm/radeon/r100.c | 10 +++---
drivers/gpu/dr
From: Christian Koenig
So we can skip the looking. Also renames sw_int to
ring_int, cause that better matches its purpose.
Signed-off-by: Christian Koenig
---
drivers/gpu/drm/radeon/evergreen.c | 32 -
drivers/gpu/drm/radeon/r100.c | 10 +++---
drivers/gpu/dr
> -Original Message-
> From: Sylvain BERTRAND [mailto:sylw...@legeek.net]
> Sent: Thursday, May 24, 2012 1:59 PM
> To: Christian König
> Cc: j.gli...@gmail.com; Koenig, Christian; dri-devel@lists.freedesktop.org
> Subject: Re: [PATCH 08/10] drm/radeon: replace pflip a
> Does the linux API mandates atomic_t to be a 32bits word?
AFAIK it is, at least for the platforms we care about.
...
>>>
>>> Then, the proper course of action would be to add to the linux API, sized
>>> atomic operation first, wouldn't it?
>>
>> No, atomic is fine for this, I t
>> Does the linux API mandates atomic_t to be a 32bits word?
>
> AFAIK it is, at least for the platforms we care about.
> ...
Then, the proper course of action would be to add to the linux API, sized
atomic operation first, wouldn't it?
--
Sylvain
> + atomic_tring_int[RADEON_NUM_RINGS];
> boolcrtc_vblank_int[RADEON_MAX_CRTCS];
> - boolpflip[RADEON_MAX_CRTCS];
> - int pflip_refcount[RADEON_MAX_CRTCS];
> + atomic_t
On Thu, May 24, 2012 at 1:53 PM, Dave Airlie wrote:
> On Thu, May 24, 2012 at 1:46 PM, Sylvain BERTRAND
> wrote:
Does the linux API mandates atomic_t to be a 32bits word?
>>>
>>> AFAIK it is, at least for the platforms we care about.
>>> ...
>>
>> Then, the proper course of action would be
On Thu, May 24, 2012 at 1:46 PM, Sylvain BERTRAND wrote:
>>> Does the linux API mandates atomic_t to be a 32bits word?
>>
>> AFAIK it is, at least for the platforms we care about.
>> ...
>
> Then, the proper course of action would be to add to the linux API, sized
> atomic operation first, wouldn'
> -Original Message-
> From: Sylvain BERTRAND [mailto:sylware at legeek.net]
> Sent: Thursday, May 24, 2012 1:59 PM
> To: Christian K?nig
> Cc: j.glisse at gmail.com; Koenig, Christian; dri-devel at
> lists.freedesktop.org
> Subject: Re: [PATCH 08/10] drm/radeon: rep
From: Christian Koenig
So we can skip the looking. Also renames sw_int to
ring_int, cause that better matches its purpose.
Signed-off-by: Christian Koenig
---
drivers/gpu/drm/radeon/evergreen.c | 32 -
drivers/gpu/drm/radeon/r100.c | 10 +++---
drivers/gpu/dr
> Does the linux API mandates atomic_t to be a 32bits word?
AFAIK it is, at least for the platforms we care about.
...
>>>
>>> Then, the proper course of action would be to add to the linux API, sized
>>> atomic operation first, wouldn't it?
>>
>> No, atomic is fine for this, I t
On Thu, May 24, 2012 at 1:53 PM, Dave Airlie wrote:
> On Thu, May 24, 2012 at 1:46 PM, Sylvain BERTRAND wrote:
Does the linux API mandates atomic_t to be a 32bits word?
>>>
>>> AFAIK it is, at least for the platforms we care about.
>>> ...
>>
>> Then, the proper course of action would be to
On Thu, May 24, 2012 at 1:46 PM, Sylvain BERTRAND wrote:
>>> Does the linux API mandates atomic_t to be a 32bits word?
>>
>> AFAIK it is, at least for the platforms we care about.
>> ...
>
> Then, the proper course of action would be to add to the linux API, sized
> atomic operation first, wouldn'
>> Does the linux API mandates atomic_t to be a 32bits word?
>
> AFAIK it is, at least for the platforms we care about.
> ...
Then, the proper course of action would be to add to the linux API, sized
atomic operation first, wouldn't it?
--
Sylvain
___
> + atomic_tring_int[RADEON_NUM_RINGS];
> boolcrtc_vblank_int[RADEON_MAX_CRTCS];
> - boolpflip[RADEON_MAX_CRTCS];
> - int pflip_refcount[RADEON_MAX_CRTCS];
> + atomic_t
From: Christian Koenig
So we can skip the looking. Also renames sw_int to
ring_int, cause that better matches its purpose.
Signed-off-by: Christian Koenig
---
drivers/gpu/drm/radeon/evergreen.c | 32 -
drivers/gpu/drm/radeon/r100.c | 10 +++---
drivers/gpu/dr
26 matches
Mail list logo
