Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs

2024-07-10 Thread Stefan Wahren
Am 05.07.24 um 23:14 schrieb Lukas Wunner: On Fri, Jul 05, 2024 at 12:16:14PM -0500, Jeremy Linton wrote: Am 05.07.24 um 17:03 schrieb Lukas Wunner: Careful there, the patch vaguely says... With that added and identified as "BCM2848", an id in use by other OSs for this device, the

Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs

2024-07-07 Thread Jeremy Linton
Hi, On 7/5/24 10:21, Stefan Wahren wrote: Hi Jeremy, Am 05.07.24 um 17:03 schrieb Lukas Wunner: On Fri, Jul 05, 2024 at 12:22:33PM +0200, Stefan Wahren wrote: Am 05.07.24 um 10:48 schrieb Lukas Wunner: The real question is whether BCM2848 platforms likewise cannot disable the clock of the

Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs

2024-07-05 Thread Lukas Wunner
On Fri, Jul 05, 2024 at 12:16:14PM -0500, Jeremy Linton wrote: > > Am 05.07.24 um 17:03 schrieb Lukas Wunner: > > > Careful there, the patch vaguely says... > > > > > > With that added and identified as "BCM2848", > > > an id in use by other OSs for this device, the dw2 > > >

Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs

2024-07-05 Thread Stefan Wahren
Hi Jeremy, Am 05.07.24 um 17:03 schrieb Lukas Wunner: On Fri, Jul 05, 2024 at 12:22:33PM +0200, Stefan Wahren wrote: Am 05.07.24 um 10:48 schrieb Lukas Wunner: The real question is whether BCM2848 platforms likewise cannot disable the clock of the dwc2 controller or whether this is specific

Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs

2024-07-05 Thread Lukas Wunner
On Fri, Jul 05, 2024 at 12:22:33PM +0200, Stefan Wahren wrote: > Am 05.07.24 um 10:48 schrieb Lukas Wunner: > > A similar issue was reported for Agilex platforms back in 2021: > > > > https://lore.kernel.org/all/5e8cbce0-3260-2971-484f-fc73a3b2b...@synopsys.com/ > > > > It was fixed by commit

Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs

2024-07-05 Thread Stefan Wahren
Am 05.07.24 um 10:48 schrieb Lukas Wunner: On Thu, Jul 04, 2024 at 03:14:50PM +0100, Florian Fainelli wrote: On 6/30/2024 4:36 PM, Stefan Wahren wrote: On resume of the Raspberry Pi the dwc2 driver fails to enable HCD_FLAG_HW_ACCESSIBLE before re-enabling the interrupts. This causes a

Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs

2024-07-05 Thread Lukas Wunner
On Thu, Jul 04, 2024 at 03:14:50PM +0100, Florian Fainelli wrote: > On 6/30/2024 4:36 PM, Stefan Wahren wrote: > > On resume of the Raspberry Pi the dwc2 driver fails to enable > > HCD_FLAG_HW_ACCESSIBLE before re-enabling the interrupts. > > This causes a situation where both handler ignore a

Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs

2024-07-04 Thread Stefan Wahren
Hi Florian, Am 04.07.24 um 16:14 schrieb Florian Fainelli: On 6/30/2024 4:36 PM, Stefan Wahren wrote: On resume of the Raspberry Pi the dwc2 driver fails to enable HCD_FLAG_HW_ACCESSIBLE before re-enabling the interrupts. This causes a situation where both handler ignore a incoming port

Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs

2024-07-04 Thread Florian Fainelli
On 6/30/2024 4:36 PM, Stefan Wahren wrote: On resume of the Raspberry Pi the dwc2 driver fails to enable HCD_FLAG_HW_ACCESSIBLE before re-enabling the interrupts. This causes a situation where both handler ignore a incoming port interrupt and force the upper layers to disable the dwc2

Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs

2024-07-01 Thread Minas Harutyunyan
On 6/30/24 19:36, Stefan Wahren wrote: > On resume of the Raspberry Pi the dwc2 driver fails to enable > HCD_FLAG_HW_ACCESSIBLE before re-enabling the interrupts. > This causes a situation where both handler ignore a incoming port > interrupt and force the upper layers to disable the dwc2

[PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs

2024-06-30 Thread Stefan Wahren
On resume of the Raspberry Pi the dwc2 driver fails to enable HCD_FLAG_HW_ACCESSIBLE before re-enabling the interrupts. This causes a situation where both handler ignore a incoming port interrupt and force the upper layers to disable the dwc2 interrupt line. This leaves the USB interface in a