[RFC] Using C99 stdint vs kernel __uX types in kernel drmUAPI (was Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from ")

2016-08-22 Thread Ken Phillis Jr
On Mon, Aug 22, 2016 at 4:12 PM, wrote: > > On Mon, 22 Aug 2016, Emil Velikov wrote: > > Although last time around people leaned towards the __uX types, if we >> have a consensus amongst drm (kernel) developers about using stdint >> ones everything should be fine. >> We just need a handful of ack

[RFC] Using C99 stdint vs kernel __uX types in kernel drmUAPI (was Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from ")

2016-08-22 Thread Daniel Vetter
On Mon, Aug 22, 2016 at 04:05:21PM +0100, Emil Velikov wrote: > On 22 August 2016 at 15:38, Daniel Vetter wrote: > > On Mon, Aug 22, 2016 at 12:38 PM, Rob Clark wrote: > >>> That said, _note_ that some applications are built with -C89 -pedantic > >>> [1] which means that using stdint.h may or may

[RFC] Using C99 stdint vs kernel __uX types in kernel drmUAPI (was Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from ")

2016-08-22 Thread Daniel Vetter
On Mon, Aug 22, 2016 at 12:38 PM, Rob Clark wrote: >> That said, _note_ that some applications are built with -C89 -pedantic >> [1] which means that using stdint.h may or may not work as expected. >> So we'll want a __STDC_VESION__ check + #error in case of pre-C99 ? >> If the affected programs ar

[RFC] Using C99 stdint vs kernel __uX types in kernel drmUAPI (was Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from ")

2016-08-22 Thread Emil Velikov
On 22 August 2016 at 15:38, Daniel Vetter wrote: > On Mon, Aug 22, 2016 at 12:38 PM, Rob Clark wrote: >>> That said, _note_ that some applications are built with -C89 -pedantic >>> [1] which means that using stdint.h may or may not work as expected. >>> So we'll want a __STDC_VESION__ check + #er

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-22 Thread ran...@sibernet.com
On Mon, 22 Aug 2016, Daniel Vetter wrote: > On Sat, Aug 20, 2016 at 8:58 PM, Emil Velikov > wrote: >> >> All I can think of is that you (?) are porting some changes from the >> kernel to libdrm or vice-versa. In the latter case please _don't_ do >> that. Work with your changes in upstream kerne

[RFC] Using C99 stdint vs kernel __uX types in kernel drmUAPI (was Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from ")

2016-08-22 Thread ran...@sibernet.com
On Mon, 22 Aug 2016, Emil Velikov wrote: > Although last time around people leaned towards the __uX types, if we > have a consensus amongst drm (kernel) developers about using stdint > ones everything should be fine. > We just need a handful of acks from the different maintainers. > My opinio

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-22 Thread ran...@sibernet.com
On Sat, 20 Aug 2016, Emil Velikov wrote: > > If you or any !Linux folks are around on XDC we should really sit down > and untangle some/all of these issues. > > Thanks > Emil > If there was to be some sort of BoF (doesn't have to be formal, and could be an after-hours event), I would inves

[RFC] Using C99 stdint vs kernel __uX types in kernel drmUAPI (was Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from ")

2016-08-22 Thread Mikko Rapeli
On Mon, Aug 22, 2016 at 09:48:10AM +0100, Emil Velikov wrote: > On 20 August 2016 at 23:31, Rob Clark wrote: > > On Sat, Aug 20, 2016 at 1:58 PM, Mikko Rapeli > > wrote: > >> Cc'ing lkml too. > >> > >> On Fri, Aug 19, 2016 at 11:54:21PM +0100, Emil Velikov wrote: > >>> Story time: > >>> I was dr

[RFC] Using C99 stdint vs kernel __uX types in kernel drmUAPI (was Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from ")

2016-08-22 Thread Christian König
Am 22.08.2016 um 10:48 schrieb Emil Velikov: > > Although last time around people leaned towards the __uX types, if we > have a consensus amongst drm (kernel) developers about using stdint > ones everything should be fine. > We just need a handful of acks from the different maintainers. For the re

[RFC] Using C99 stdint vs kernel __uX types in kernel drmUAPI (was Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from ")

2016-08-22 Thread Emil Velikov
On 20 August 2016 at 23:31, Rob Clark wrote: > On Sat, Aug 20, 2016 at 1:58 PM, Mikko Rapeli wrote: >> Cc'ing lkml too. >> >> On Fri, Aug 19, 2016 at 11:54:21PM +0100, Emil Velikov wrote: >>> Story time: >>> I was dreaming of a day were we can stop installing these headers, >>> thus making deprec

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-22 Thread Daniel Vetter
On Sat, Aug 20, 2016 at 8:58 PM, Emil Velikov wrote: > On 20 August 2016 at 16:08, Marek Olšák wrote: >> On Sat, Aug 20, 2016 at 2:20 PM, Emil Velikov >> wrote: >>> On 20 August 2016 at 12:47, Marek Olšák wrote: On Sat, Aug 20, 2016 at 1:08 PM, Emil Velikov >>> gmail.com> wrote:

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-22 Thread Daniel Vetter
On Sat, Aug 20, 2016 at 2:20 PM, Emil Velikov wrote: >> While I understand some people want to discuss this further, these >> patches must land first in order bring back the compatibility with >> libdrm. > This is where the misunderstanding lies - there _must_ _not_ be > compatible with the libdr

[RFC] Using C99 stdint vs kernel __uX types in kernel drmUAPI (was Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from ")

2016-08-22 Thread Rob Clark
On Mon, Aug 22, 2016 at 4:48 AM, Emil Velikov wrote: > On 20 August 2016 at 23:31, Rob Clark wrote: >> On Sat, Aug 20, 2016 at 1:58 PM, Mikko Rapeli wrote: >>> Cc'ing lkml too. >>> >>> On Fri, Aug 19, 2016 at 11:54:21PM +0100, Emil Velikov wrote: Story time: I was dreaming of a day we

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-21 Thread Christian König
Am 20.08.2016 um 19:58 schrieb Mikko Rapeli: > Cc'ing lkml too. > > On Fri, Aug 19, 2016 at 11:54:21PM +0100, Emil Velikov wrote: >> Story time: >> I was dreaming of a day were we can stop installing these headers, >> thus making deprecation a bit easier process. >> Yet after failing to convince Da

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Mikko Rapeli
Cc'ing lkml. On Sat, Aug 20, 2016 at 12:05:54PM +0200, Marek Olšák wrote: > On Sat, Aug 20, 2016 at 12:54 AM, Emil Velikov > wrote: > > On 19 August 2016 at 15:26, Christian König > > wrote: > >> Am 19.08.2016 um 15:50 schrieb Marek Olšák: > >>> > >>> From: Marek Olšák > >>> > >>> This

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Mikko Rapeli
Cc'ing lkml. On Fri, Aug 19, 2016 at 09:18:24PM -0500, Ken Phillis Jr wrote: > On Fri, Aug 19, 2016 at 8:46 PM, Rob Clark wrote: > > > perhaps, but if the target audience for driver specific APIs is > > libdrm/mesa, which already uses stdint types, then I fail to see the > > point.. > > > > It i

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Mikko Rapeli
Cc'ing lkml too. On Fri, Aug 19, 2016 at 11:54:21PM +0100, Emil Velikov wrote: > Story time: > I was dreaming of a day were we can stop installing these headers, > thus making deprecation a bit easier process. > Yet after failing to convince Dave and Daniel on a number of occasions > I've accepted

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Marek Olšák
On Sat, Aug 20, 2016 at 8:28 PM, Marek Olšák wrote: > On Sat, Aug 20, 2016 at 8:08 PM, Mikko Rapeli wrote: >> Cc'ing lkml. >> >> On Sat, Aug 20, 2016 at 12:05:54PM +0200, Marek Olšák wrote: >>> On Sat, Aug 20, 2016 at 12:54 AM, Emil Velikov >> gmail.com> wrote: >>> > On 19 August 2016 at 15:2

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Marek Olšák
On Sat, Aug 20, 2016 at 8:08 PM, Mikko Rapeli wrote: > Cc'ing lkml. > > On Sat, Aug 20, 2016 at 12:05:54PM +0200, Marek Olšák wrote: >> On Sat, Aug 20, 2016 at 12:54 AM, Emil Velikov >> wrote: >> > On 19 August 2016 at 15:26, Christian König >> > wrote: >> >> Am 19.08.2016 um 15:50 schrieb

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Emil Velikov
On 20 August 2016 at 16:08, Marek Olšák wrote: > On Sat, Aug 20, 2016 at 2:20 PM, Emil Velikov > wrote: >> On 20 August 2016 at 12:47, Marek Olšák wrote: >>> On Sat, Aug 20, 2016 at 1:08 PM, Emil Velikov >>> wrote: On 20 August 2016 at 11:05, Marek Olšák wrote: > On Sat, Aug 2

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Rob Clark
On Sat, Aug 20, 2016 at 1:58 PM, Mikko Rapeli wrote: > Cc'ing lkml too. > > On Fri, Aug 19, 2016 at 11:54:21PM +0100, Emil Velikov wrote: >> Story time: >> I was dreaming of a day were we can stop installing these headers, >> thus making deprecation a bit easier process. >> Yet after failing to co

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Marek Olšák
On Sat, Aug 20, 2016 at 2:20 PM, Emil Velikov wrote: > On 20 August 2016 at 12:47, Marek Olšák wrote: >> On Sat, Aug 20, 2016 at 1:08 PM, Emil Velikov >> wrote: >>> On 20 August 2016 at 11:05, Marek Olšák wrote: On Sat, Aug 20, 2016 at 12:54 AM, Emil Velikov >>> gmail.com> wrote: >>>

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Marek Olšák
On Sat, Aug 20, 2016 at 1:08 PM, Emil Velikov wrote: > On 20 August 2016 at 11:05, Marek Olšák wrote: >> On Sat, Aug 20, 2016 at 12:54 AM, Emil Velikov >> wrote: >>> On 19 August 2016 at 15:26, Christian König >>> wrote: Am 19.08.2016 um 15:50 schrieb Marek Olšák: > > From:

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Emil Velikov
On 20 August 2016 at 12:47, Marek Olšák wrote: > On Sat, Aug 20, 2016 at 1:08 PM, Emil Velikov > wrote: >> On 20 August 2016 at 11:05, Marek Olšák wrote: >>> On Sat, Aug 20, 2016 at 12:54 AM, Emil Velikov >> gmail.com> wrote: On 19 August 2016 at 15:26, Christian König wrote: >

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Emil Velikov
On 20 August 2016 at 11:05, Marek Olšák wrote: > On Sat, Aug 20, 2016 at 12:54 AM, Emil Velikov > wrote: >> On 19 August 2016 at 15:26, Christian König >> wrote: >>> Am 19.08.2016 um 15:50 schrieb Marek Olšák: From: Marek Olšák This reverts commit 2ce9dde0d47f2f94ab

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Marek Olšák
On Sat, Aug 20, 2016 at 12:54 AM, Emil Velikov wrote: > On 19 August 2016 at 15:26, Christian König > wrote: >> Am 19.08.2016 um 15:50 schrieb Marek Olšák: >>> >>> From: Marek Olšák >>> >>> This reverts commit 2ce9dde0d47f2f94ab25c73a30596a7328bcdf1f. >>> >>> See the comment in the code.

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Emil Velikov
On 19 August 2016 at 15:26, Christian König wrote: > Am 19.08.2016 um 15:50 schrieb Marek Olšák: >> >> From: Marek Olšák >> >> This reverts commit 2ce9dde0d47f2f94ab25c73a30596a7328bcdf1f. >> >> See the comment in the code. Basically, don't do cleanups in this header. >> >> Signed-off-by: Ma

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Rob Clark
On Fri, Aug 19, 2016 at 9:23 PM, Ken Phillis Jr wrote: > On Fri, Aug 19, 2016 at 6:32 PM, Rob Clark wrote: >> >> tbh, I'm all in favor of making it easier to sync kernel headers to >> libdrm, etc. >> >> But kernel *does* have stdint types. Just (for some reason that >> completely baffles me) not

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Ken Phillis Jr
On Fri, Aug 19, 2016 at 8:46 PM, Rob Clark wrote: > perhaps, but if the target audience for driver specific APIs is > libdrm/mesa, which already uses stdint types, then I fail to see the > point.. > > It is a bit difference scenario for some of the core kms ioctls which > are not driver specific.

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Ken Phillis Jr
On Fri, Aug 19, 2016 at 6:32 PM, Rob Clark wrote: > tbh, I'm all in favor of making it easier to sync kernel headers to > libdrm, etc. > > But kernel *does* have stdint types. Just (for some reason that > completely baffles me) not in stdint.h so we can't include that from > the uapi headers the

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Rob Clark
On Fri, Aug 19, 2016 at 6:54 PM, Emil Velikov wrote: > On 19 August 2016 at 15:26, Christian König > wrote: >> Am 19.08.2016 um 15:50 schrieb Marek Olšák: >>> >>> From: Marek Olšák >>> >>> This reverts commit 2ce9dde0d47f2f94ab25c73a30596a7328bcdf1f. >>> >>> See the comment in the code. B

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Marek Olšák
On Fri, Aug 19, 2016 at 7:12 PM, Daniel Vetter wrote: > On Fri, Aug 19, 2016 at 7:11 PM, Daniel Vetter wrote: >> On Fri, Aug 19, 2016 at 5:22 PM, Marek Olšák wrote: >>> On Fri, Aug 19, 2016 at 4:52 PM, Mikko Rapeli >>> wrote: On Fri, Aug 19, 2016 at 04:26:40PM +0200, Christian König wr

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Daniel Vetter
On Fri, Aug 19, 2016 at 7:11 PM, Daniel Vetter wrote: > On Fri, Aug 19, 2016 at 5:22 PM, Marek Olšák wrote: >> On Fri, Aug 19, 2016 at 4:52 PM, Mikko Rapeli wrote: >>> On Fri, Aug 19, 2016 at 04:26:40PM +0200, Christian König wrote: Am 19.08.2016 um 15:50 schrieb Marek Olšák: >Fro

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Daniel Vetter
On Fri, Aug 19, 2016 at 5:22 PM, Marek Olšák wrote: > On Fri, Aug 19, 2016 at 4:52 PM, Mikko Rapeli wrote: >> On Fri, Aug 19, 2016 at 04:26:40PM +0200, Christian König wrote: >>> Am 19.08.2016 um 15:50 schrieb Marek Olšák: >>> >From: Marek Olšák >>> > >>> >This reverts commit 2ce9dde0d47f

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Mikko Rapeli
On Fri, Aug 19, 2016 at 04:26:40PM +0200, Christian König wrote: > Am 19.08.2016 um 15:50 schrieb Marek Olšák: > >From: Marek Olšák > > > >This reverts commit 2ce9dde0d47f2f94ab25c73a30596a7328bcdf1f. > > > >See the comment in the code. Basically, don't do cleanups in this header. > > > >Sign

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Marek Olšák
On Fri, Aug 19, 2016 at 4:52 PM, Mikko Rapeli wrote: > On Fri, Aug 19, 2016 at 04:26:40PM +0200, Christian König wrote: >> Am 19.08.2016 um 15:50 schrieb Marek Olšák: >> >From: Marek Olšák >> > >> >This reverts commit 2ce9dde0d47f2f94ab25c73a30596a7328bcdf1f. >> > >> >See the comment in the

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Christian König
Am 19.08.2016 um 15:50 schrieb Marek Olšák: > From: Marek Olšák > > This reverts commit 2ce9dde0d47f2f94ab25c73a30596a7328bcdf1f. > > See the comment in the code. Basically, don't do cleanups in this header. > > Signed-off-by: Marek Olšák I completely agree with you that this was a bad mov

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Marek Olšák
From: Marek Olšák This reverts commit 2ce9dde0d47f2f94ab25c73a30596a7328bcdf1f. See the comment in the code. Basically, don't do cleanups in this header. Signed-off-by: Marek Olšák --- include/uapi/drm/amdgpu_drm.h | 295 +- 1 file changed, 150 inse