Hi Joel,
Sounds like a good idea! One comment though:
> @@ -111,10 +112,13 @@ static int aspeed_gfx_load(struct drm_device *drm)
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> - priv->scu = syscon_regmap_lookup_by_compatible("aspeed,ast2500-scu");
> +
On Tue, 2 Feb 2021 at 04:39, Jeremy Kerr wrote:
>
> Hi Joel,
>
> Sounds like a good idea! One comment though:
>
> > @@ -111,10 +112,13 @@ static int aspeed_gfx_load(struct drm_device *drm)
> > if (IS_ERR(priv->base))
> > return PTR_ERR(priv->base);
> >
> > -
This scales better to multiple families of SoC. The lookup by compatible
can be removed in a future change.
Signed-off-by: Joel Stanley
---
drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git