[PATCH 1/2] drm/crtc-helper: fix locking for drm_helper_disable_unused_functions

2014-03-21 Thread Thierry Reding
On Thu, Mar 20, 2014 at 02:26:34PM +0100, Daniel Vetter wrote: [...] > The right fix therefore is to split this helper into an internal and > external version and add the required locking to the function exported > to drivers. > > This remedies locking inconsistencies exposed by me adding locking

[PATCH 1/2] drm/crtc-helper: fix locking for drm_helper_disable_unused_functions

2014-03-20 Thread Daniel Vetter
We have two calling contexts for thise function: - In the crtc helper code itself as part of the ->set_config implementation. In this calling context all modeset locks are already held, as they should. - In drivers not implementing fastboot before the fbdev/fbcon setup and initialization.

[PATCH 1/2] drm/crtc-helper: fix locking for drm_helper_disable_unused_functions

2014-03-20 Thread Daniel Vetter
We have two calling contexts for thise function: - In the crtc helper code itself as part of the ->set_config implementation. In this calling context all modeset locks are already held, as they should. - In drivers not implementing fastboot before the fbdev/fbcon setup and initialization.

[PATCH 1/2] drm/crtc-helper: fix locking for drm_helper_disable_unused_functions

2014-03-20 Thread Chris Wilson
On Thu, Mar 20, 2014 at 02:26:34PM +0100, Daniel Vetter wrote: > We have two calling contexts for thise function: > > - In the crtc helper code itself as part of the ->set_config > implementation. In this calling context all modeset locks are > already held, as they should. > > - In drivers

[PATCH 1/2] drm/crtc-helper: fix locking for drm_helper_disable_unused_functions

2014-03-20 Thread Chris Wilson
On Thu, Mar 20, 2014 at 02:01:21PM +0100, Daniel Vetter wrote: > We have two calling contexts for thise function: > > - In the crtc helper code itself as part of the ->set_config > implementation. In this calling context all modeset locks are > already held, as they should. > > - In drivers