Re: [PATCH 1/2] drm/i915/gem: Return -EINVAL instead of '0'

2024-06-18 Thread Andi Shyti
Hi Lucas, On Mon, Jun 17, 2024 at 05:29:24PM -0500, Lucas De Marchi wrote: > On Mon, Jun 17, 2024 at 08:38:20PM GMT, Andi Shyti wrote: > > On Mon, Jun 17, 2024 at 10:46:07AM -0500, Lucas De Marchi wrote: > > > On Mon, Jun 17, 2024 at 04:22:11PM GMT, Andi Shyti wrote: > > > > On Mon, Jun 17, 2024 a

Re: [PATCH 1/2] drm/i915/gem: Return -EINVAL instead of '0'

2024-06-17 Thread Lucas De Marchi
On Mon, Jun 17, 2024 at 08:38:20PM GMT, Andi Shyti wrote: On Mon, Jun 17, 2024 at 10:46:07AM -0500, Lucas De Marchi wrote: On Mon, Jun 17, 2024 at 04:22:11PM GMT, Andi Shyti wrote: > On Mon, Jun 17, 2024 at 07:55:10AM -0500, Lucas De Marchi wrote: > > On Sun, Jun 16, 2024 at 09:03:48AM GMT, Andi

Re: [PATCH 1/2] drm/i915/gem: Return -EINVAL instead of '0'

2024-06-17 Thread Andi Shyti
On Mon, Jun 17, 2024 at 10:46:07AM -0500, Lucas De Marchi wrote: > On Mon, Jun 17, 2024 at 04:22:11PM GMT, Andi Shyti wrote: > > On Mon, Jun 17, 2024 at 07:55:10AM -0500, Lucas De Marchi wrote: > > > On Sun, Jun 16, 2024 at 09:03:48AM GMT, Andi Shyti wrote: > > > > Commit 05da7d9f717b ("drm/i915/ge

Re: [PATCH 1/2] drm/i915/gem: Return -EINVAL instead of '0'

2024-06-17 Thread Lucas De Marchi
On Mon, Jun 17, 2024 at 04:22:11PM GMT, Andi Shyti wrote: On Mon, Jun 17, 2024 at 07:55:10AM -0500, Lucas De Marchi wrote: On Sun, Jun 16, 2024 at 09:03:48AM GMT, Andi Shyti wrote: > Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup > warning") returns '0' from i915_gem_stolen_lmem

Re: [PATCH 1/2] drm/i915/gem: Return -EINVAL instead of '0'

2024-06-17 Thread Andi Shyti
On Mon, Jun 17, 2024 at 07:55:10AM -0500, Lucas De Marchi wrote: > On Sun, Jun 16, 2024 at 09:03:48AM GMT, Andi Shyti wrote: > > Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup > > warning") returns '0' from i915_gem_stolen_lmem_setup(), but it's > > supposed to return a pointer to

Re: [PATCH 1/2] drm/i915/gem: Return -EINVAL instead of '0'

2024-06-17 Thread Lucas De Marchi
On Sun, Jun 16, 2024 at 09:03:48AM GMT, Andi Shyti wrote: Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup warning") returns '0' from i915_gem_stolen_lmem_setup(), but it's supposed to return a pointer to the intel_memory_region structure. Sparse complains with the following messa

[PATCH 1/2] drm/i915/gem: Return -EINVAL instead of '0'

2024-06-16 Thread Andi Shyti
Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup warning") returns '0' from i915_gem_stolen_lmem_setup(), but it's supposed to return a pointer to the intel_memory_region structure. Sparse complains with the following message: >> drivers/gpu/drm/i915/gem/i915_gem_stolen.c:943:32: s