Re: [PATCH 1/2] drm/i915: Seal races between async GPU cancellation, retirement and signaling

2019-05-09 Thread Daniel Vetter
On Wed, May 08, 2019 at 09:30:42PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2019-05-08 13:53:30) > > On Wed, May 8, 2019 at 2:06 PM Chris Wilson > > wrote: > > > > > > Currently there is an underlying assumption that i915_request_unsubmit() > > > is synchronous wrt the GPU -- that is

Re: [PATCH 1/2] drm/i915: Seal races between async GPU cancellation, retirement and signaling

2019-05-08 Thread Chris Wilson
Quoting Daniel Vetter (2019-05-08 13:53:30) > On Wed, May 8, 2019 at 2:06 PM Chris Wilson wrote: > > > > Currently there is an underlying assumption that i915_request_unsubmit() > > is synchronous wrt the GPU -- that is the request is no longer in flight > > as we remove it. In the near future

Re: [PATCH 1/2] drm/i915: Seal races between async GPU cancellation, retirement and signaling

2019-05-08 Thread Daniel Vetter
On Wed, May 8, 2019 at 2:06 PM Chris Wilson wrote: > > Currently there is an underlying assumption that i915_request_unsubmit() > is synchronous wrt the GPU -- that is the request is no longer in flight > as we remove it. In the near future that may change, and this may upset > our signaling as

[PATCH 1/2] drm/i915: Seal races between async GPU cancellation, retirement and signaling

2019-05-08 Thread Chris Wilson
Currently there is an underlying assumption that i915_request_unsubmit() is synchronous wrt the GPU -- that is the request is no longer in flight as we remove it. In the near future that may change, and this may upset our signaling as we can process an interrupt for that request while it is no