Re: [PATCH 1/2] drm/nouveau/device: avoid usage of list iterator after loop

2023-03-07 Thread Lyude Paul
On Wed, 2023-03-01 at 18:25 +0100, Jakob Koschel wrote: > If potentially no valid element is found, 'pstate' would contain an > invalid pointer past the iterator loop. To ensure 'pstate' is always > valid, we only set it if the correct element was found. That allows > adding a BUG_ON in case the

[PATCH 1/2] drm/nouveau/device: avoid usage of list iterator after loop

2023-03-02 Thread Jakob Koschel
If potentially no valid element is found, 'pstate' would contain an invalid pointer past the iterator loop. To ensure 'pstate' is always valid, we only set it if the correct element was found. That allows adding a BUG_ON in case the code works incorrectly, exposing currently undetectable potential