Re: [PATCH 1/2] drm/panthor: Fix IO-page mmap() for 32-bit userspace on 64-bit kernel

2024-03-25 Thread Boris Brezillon
On Mon, 25 Mar 2024 11:12:40 + Steven Price wrote: > On 25/03/2024 10:41, Boris Brezillon wrote: > > When mapping an IO region, the pseudo-file offset is dependent on the > > userspace architecture. panthor_device_mmio_offset() abstract that away > > for us by turning a userspace MMIO offset

Re: [PATCH 1/2] drm/panthor: Fix IO-page mmap() for 32-bit userspace on 64-bit kernel

2024-03-25 Thread Steven Price
On 25/03/2024 10:41, Boris Brezillon wrote: > When mapping an IO region, the pseudo-file offset is dependent on the > userspace architecture. panthor_device_mmio_offset() abstract that away > for us by turning a userspace MMIO offset into its kernel equivalent, > but we were not updating vm_area_st

[PATCH 1/2] drm/panthor: Fix IO-page mmap() for 32-bit userspace on 64-bit kernel

2024-03-25 Thread Boris Brezillon
When mapping an IO region, the pseudo-file offset is dependent on the userspace architecture. panthor_device_mmio_offset() abstract that away for us by turning a userspace MMIO offset into its kernel equivalent, but we were not updating vm_area_struct::vm_pgoff accordingly, leading us to attach the