Re: [PATCH 1/2] drm/vkms: Use index instead of 0 in possible crtc

2019-06-18 Thread Rodrigo Siqueira
On Tue, Jun 18, 2019 at 2:18 AM Simon Ser wrote: > > On Tuesday, June 18, 2019 5:19 AM, Rodrigo Siqueira > wrote: > > I made the patch, but when I started to write the commit message, I just > > realized that I did not understand why possible_crtcs should not be > > equal zero. Why can we not us

Re: [PATCH 1/2] drm/vkms: Use index instead of 0 in possible crtc

2019-06-17 Thread Simon Ser
On Tuesday, June 18, 2019 5:19 AM, Rodrigo Siqueira wrote: > I made the patch, but when I started to write the commit message, I just > realized that I did not understand why possible_crtcs should not be > equal zero. Why can we not use zero? Hi, possible_crtcs is a bitfield. If it's zero, it m

Re: [PATCH 1/2] drm/vkms: Use index instead of 0 in possible crtc

2019-06-17 Thread Rodrigo Siqueira
On 06/07, Daniel Vetter wrote: > On Fri, Jun 07, 2019 at 11:37:55AM -0300, Rodrigo Siqueira wrote: > > On Fri, Jun 7, 2019 at 4:40 AM Daniel Vetter wrote: > > > > > > On Thu, Jun 06, 2019 at 07:40:38PM -0300, Rodrigo Siqueira wrote: > > > > When vkms calls drm_universal_plane_init(), it sets 0 for

Re: [PATCH 1/2] drm/vkms: Use index instead of 0 in possible crtc

2019-06-07 Thread Daniel Vetter
On Fri, Jun 07, 2019 at 11:37:55AM -0300, Rodrigo Siqueira wrote: > On Fri, Jun 7, 2019 at 4:40 AM Daniel Vetter wrote: > > > > On Thu, Jun 06, 2019 at 07:40:38PM -0300, Rodrigo Siqueira wrote: > > > When vkms calls drm_universal_plane_init(), it sets 0 for the > > > possible_crtcs parameter which

Re: [PATCH 1/2] drm/vkms: Use index instead of 0 in possible crtc

2019-06-07 Thread Rodrigo Siqueira
On Fri, Jun 7, 2019 at 4:40 AM Daniel Vetter wrote: > > On Thu, Jun 06, 2019 at 07:40:38PM -0300, Rodrigo Siqueira wrote: > > When vkms calls drm_universal_plane_init(), it sets 0 for the > > possible_crtcs parameter which works well for a single encoder and > > connector; however, this approach i

Re: [PATCH 1/2] drm/vkms: Use index instead of 0 in possible crtc

2019-06-07 Thread Daniel Vetter
On Thu, Jun 06, 2019 at 07:40:38PM -0300, Rodrigo Siqueira wrote: > When vkms calls drm_universal_plane_init(), it sets 0 for the > possible_crtcs parameter which works well for a single encoder and > connector; however, this approach is not flexible and does not fit well > for vkms. This commit ad

[PATCH 1/2] drm/vkms: Use index instead of 0 in possible crtc

2019-06-06 Thread Rodrigo Siqueira
When vkms calls drm_universal_plane_init(), it sets 0 for the possible_crtcs parameter which works well for a single encoder and connector; however, this approach is not flexible and does not fit well for vkms. This commit adds an index parameter for vkms_plane_init() which makes code flexible and