Re: [PATCH 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-05-25 Thread Ryan Walklin
On Sun, 26 May 2024, at 10:49 AM, きくちゃんさん wrote: > Hi Ryan, > > How about to use "anbernic,rg35xx-panel" ? > It's not generic though, some other drivers use similar strings already. Could do, although I think it is used for more than one of the Anbernic devices, so "anbernic,wl-355608-a8" might

Re: [PATCH 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-05-25 Thread きくちゃんさん
Hi Ryan, How about to use "anbernic,rg35xx-panel" ? It's not generic though, some other drivers use similar strings already. Regards, kikuchan.

Re: [PATCH 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-05-25 Thread Ryan Walklin
On Sun, 26 May 2024, at 3:22 AM, Conor Dooley wrote: >> >> Thanks, I don't actually know the vendor, would it be acceptable to just use >> "wl"? > > You mean, "wl,355608-a8"? I did a wee bit of googling of the thing, and > yeah, there's nothing that a surface level search turns up for it - >

Re: [PATCH 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-05-25 Thread Conor Dooley
On Sat, May 25, 2024 at 09:26:48AM +1200, Ryan Walklin wrote: > On Sat, 25 May 2024, at 7:10 AM, Conor Dooley wrote: > > Thanks for the review! > > >> + > >> +properties: > >> + compatible: > >> +const: wl-355608-a8 > > > > You're missing a vendor prefix here. And when you add it, update

Re: [PATCH 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-05-24 Thread Ryan Walklin
On Sat, 25 May 2024, at 7:10 AM, Conor Dooley wrote: Thanks for the review! >> + >> +properties: >> + compatible: >> +const: wl-355608-a8 > > You're missing a vendor prefix here. And when you add it, update the > filename to match. Thanks, I don't actually know the vendor, would it be

Re: [PATCH 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-05-24 Thread Conor Dooley
On Fri, May 24, 2024 at 10:33:13PM +1200, Ryan Walklin wrote: > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown > OEM, used in a number of handheld gaming devices made by Anbernic. > > Add a device tree binding for the panel. > > Signed-off-by: Ryan Walklin > --- >

[PATCH 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-05-24 Thread Ryan Walklin
The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM, used in a number of handheld gaming devices made by Anbernic. Add a device tree binding for the panel. Signed-off-by: Ryan Walklin --- .../bindings/display/panel/wl-355608-a8.yaml | 68 +++ 1 file

Re: [PATCH 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-05-24 Thread Rob Herring (Arm)
On Fri, 24 May 2024 22:33:13 +1200, Ryan Walklin wrote: > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown > OEM, used in a number of handheld gaming devices made by Anbernic. > > Add a device tree binding for the panel. > > Signed-off-by: Ryan Walklin > --- >