[PATCH 1/2] omap2+: add drm device

2012-02-17 Thread Gross, Andy
On Mon, Jan 23, 2012 at 11:24 AM, Cousson, Benoit wrote: > >> + if (oh) { >> + dmm_platdata.base = omap_hwmod_get_mpu_rt_va(oh); >> + dmm_platdata.irq = oh->mpu_irqs[0].irq; >> > > These are internal hwmod attributes that should not be retrieved here. > They are

Re: [PATCH 1/2] omap2+: add drm device

2012-02-17 Thread Gross, Andy
On Mon, Jan 23, 2012 at 11:24 AM, Cousson, Benoit wrote: > >> + if (oh) { >> + dmm_platdata.base = omap_hwmod_get_mpu_rt_va(oh); >> + dmm_platdata.irq = oh->mpu_irqs[0].irq; >> > > These are internal hwmod attributes that should not be retrieved here. > They are

Re: [PATCH 1/2] omap2+: add drm device

2012-02-09 Thread Rob Clark
On Thu, Feb 9, 2012 at 11:28 AM, Greg KH wrote: > On Fri, Jan 13, 2012 at 02:41:59PM -0600, Rob Clark wrote: >> From: Rob Clark >> >> Register OMAP DRM/KMS platform device, and reserve a CMA region for >> the device to use for buffer allocation. >> >> v1: initial patch >> v2: move platform data s

Re: [PATCH 1/2] omap2+: add drm device

2012-02-09 Thread Greg KH
On Fri, Jan 13, 2012 at 02:41:59PM -0600, Rob Clark wrote: > From: Rob Clark > > Register OMAP DRM/KMS platform device, and reserve a CMA region for > the device to use for buffer allocation. > > v1: initial patch > v2: move platform data structs into plat-omap to avoid having to > #include

[PATCH 1/2] omap2+: add drm device

2012-02-09 Thread Rob Clark
On Thu, Feb 9, 2012 at 11:28 AM, Greg KH wrote: > On Fri, Jan 13, 2012 at 02:41:59PM -0600, Rob Clark wrote: >> From: Rob Clark >> >> Register OMAP DRM/KMS platform device, and reserve a CMA region for >> the device to use for buffer allocation. >> >> v1: initial patch >> v2: move platform data s

[PATCH 1/2] omap2+: add drm device

2012-02-09 Thread Greg KH
On Fri, Jan 13, 2012 at 02:41:59PM -0600, Rob Clark wrote: > From: Rob Clark > > Register OMAP DRM/KMS platform device, and reserve a CMA region for > the device to use for buffer allocation. > > v1: initial patch > v2: move platform data structs into plat-omap to avoid having to > #include

[PATCH 1/2] omap2+: add drm device

2012-01-25 Thread Rob Clark
On Tue, Jan 24, 2012 at 8:32 PM, Rob Clark wrote: > On Tue, Jan 24, 2012 at 8:17 PM, Felipe Contreras > wrote: >> On Tue, Jan 24, 2012 at 5:54 PM, Rob Clark wrote: >>> On Tue, Jan 24, 2012 at 9:33 AM, Felipe Contreras >>> wrote: On Mon, Jan 16, 2012 at 11:24 PM, Rob Clark wrote: >>>

Re: [PATCH 1/2] omap2+: add drm device

2012-01-25 Thread Rob Clark
On Tue, Jan 24, 2012 at 8:32 PM, Rob Clark wrote: > On Tue, Jan 24, 2012 at 8:17 PM, Felipe Contreras > wrote: >> On Tue, Jan 24, 2012 at 5:54 PM, Rob Clark wrote: >>> On Tue, Jan 24, 2012 at 9:33 AM, Felipe Contreras >>> wrote: On Mon, Jan 16, 2012 at 11:24 PM, Rob Clark wrote: > On

[PATCH 1/2] omap2+: add drm device

2012-01-25 Thread Felipe Contreras
On Tue, Jan 24, 2012 at 5:54 PM, Rob Clark wrote: > On Tue, Jan 24, 2012 at 9:33 AM, Felipe Contreras > wrote: >> On Mon, Jan 16, 2012 at 11:24 PM, Rob Clark wrote: >>> On Mon, Jan 16, 2012 at 2:37 PM, Felipe Contreras >>> wrote: On Mon, Jan 16, 2012 at 7:01 PM, Rob Clark wrote: > On

[PATCH 1/2] omap2+: add drm device

2012-01-24 Thread Rob Clark
On Tue, Jan 24, 2012 at 8:17 PM, Felipe Contreras wrote: > On Tue, Jan 24, 2012 at 5:54 PM, Rob Clark wrote: >> On Tue, Jan 24, 2012 at 9:33 AM, Felipe Contreras >> wrote: >>> On Mon, Jan 16, 2012 at 11:24 PM, Rob Clark wrote: On Mon, Jan 16, 2012 at 2:37 PM, Felipe Contreras wrote:

Re: [PATCH 1/2] omap2+: add drm device

2012-01-24 Thread Rob Clark
On Tue, Jan 24, 2012 at 8:17 PM, Felipe Contreras wrote: > On Tue, Jan 24, 2012 at 5:54 PM, Rob Clark wrote: >> On Tue, Jan 24, 2012 at 9:33 AM, Felipe Contreras >> wrote: >>> On Mon, Jan 16, 2012 at 11:24 PM, Rob Clark wrote: On Mon, Jan 16, 2012 at 2:37 PM, Felipe Contreras wrote:

Re: [PATCH 1/2] omap2+: add drm device

2012-01-24 Thread Felipe Contreras
On Tue, Jan 24, 2012 at 5:54 PM, Rob Clark wrote: > On Tue, Jan 24, 2012 at 9:33 AM, Felipe Contreras > wrote: >> On Mon, Jan 16, 2012 at 11:24 PM, Rob Clark wrote: >>> On Mon, Jan 16, 2012 at 2:37 PM, Felipe Contreras >>> wrote: On Mon, Jan 16, 2012 at 7:01 PM, Rob Clark wrote: > On

[PATCH 1/2] omap2+: add drm device

2012-01-24 Thread Felipe Contreras
On Mon, Jan 16, 2012 at 11:24 PM, Rob Clark wrote: > On Mon, Jan 16, 2012 at 2:37 PM, Felipe Contreras > wrote: >> On Mon, Jan 16, 2012 at 7:01 PM, Rob Clark wrote: >>> On Mon, Jan 16, 2012 at 10:59 AM, Felipe Contreras >>> wrote: #if defined(CONFIG_DRM_OMAP) || defined(CONFIG_DRM_OMAP_MOD

Re: [PATCH 1/2] omap2+: add drm device

2012-01-24 Thread Rob Clark
On Tue, Jan 24, 2012 at 9:33 AM, Felipe Contreras wrote: > On Mon, Jan 16, 2012 at 11:24 PM, Rob Clark wrote: >> On Mon, Jan 16, 2012 at 2:37 PM, Felipe Contreras >> wrote: >>> On Mon, Jan 16, 2012 at 7:01 PM, Rob Clark wrote: On Mon, Jan 16, 2012 at 10:59 AM, Felipe Contreras wrote:

[PATCH 1/2] omap2+: add drm device

2012-01-24 Thread Rob Clark
On Tue, Jan 24, 2012 at 9:33 AM, Felipe Contreras wrote: > On Mon, Jan 16, 2012 at 11:24 PM, Rob Clark wrote: >> On Mon, Jan 16, 2012 at 2:37 PM, Felipe Contreras >> wrote: >>> On Mon, Jan 16, 2012 at 7:01 PM, Rob Clark wrote: On Mon, Jan 16, 2012 at 10:59 AM, Felipe Contreras wrote:

Re: [PATCH 1/2] omap2+: add drm device

2012-01-24 Thread Felipe Contreras
On Mon, Jan 16, 2012 at 11:24 PM, Rob Clark wrote: > On Mon, Jan 16, 2012 at 2:37 PM, Felipe Contreras > wrote: >> On Mon, Jan 16, 2012 at 7:01 PM, Rob Clark wrote: >>> On Mon, Jan 16, 2012 at 10:59 AM, Felipe Contreras >>> wrote: #if defined(CONFIG_DRM_OMAP) || defined(CONFIG_DRM_OMAP_MOD

[PATCH 1/2] omap2+: add drm device

2012-01-23 Thread Cousson, Benoit
Hi Rob, On 1/13/2012 9:41 PM, Rob Clark wrote: > From: Rob Clark [...] > +static int __init omap_init_gpu(void) Why is the function to init drm device is named gpu? > +{ > + struct omap_hwmod *oh = NULL; > + > + /* lookup and populate the DMM information, if present - OMAP4+ */ > +

Re: [PATCH 1/2] omap2+: add drm device

2012-01-23 Thread Cousson, Benoit
Hi Rob, On 1/13/2012 9:41 PM, Rob Clark wrote: From: Rob Clark [...] +static int __init omap_init_gpu(void) Why is the function to init drm device is named gpu? +{ + struct omap_hwmod *oh = NULL; + + /* lookup and populate the DMM information, if present - OMAP4+ */ + o

[PATCH 1/2] omap2+: add drm device

2012-01-23 Thread Rob Clark
On Mon, Jan 23, 2012 at 11:24 AM, Cousson, Benoit wrote: > Hi Rob, > > On 1/13/2012 9:41 PM, Rob Clark wrote: >> >> From: Rob Clark > > > [...] > >> +static int __init omap_init_gpu(void) > > > Why is the function to init drm device is named gpu? > drm drivers are typically gpu drivers (although

Re: [PATCH 1/2] omap2+: add drm device

2012-01-23 Thread Rob Clark
On Mon, Jan 23, 2012 at 11:24 AM, Cousson, Benoit wrote: > Hi Rob, > > On 1/13/2012 9:41 PM, Rob Clark wrote: >> >> From: Rob Clark > > > [...] > >> +static int __init omap_init_gpu(void) > > > Why is the function to init drm device is named gpu? > drm drivers are typically gpu drivers (although

[PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Felipe Contreras
On Mon, Jan 16, 2012 at 7:01 PM, Rob Clark wrote: > On Mon, Jan 16, 2012 at 10:59 AM, Felipe Contreras > wrote: >> On Mon, Jan 16, 2012 at 6:37 PM, Rob Clark wrote: >>> On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras >>> wrote: On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark wrote: >>

[PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Felipe Contreras
On Mon, Jan 16, 2012 at 6:37 PM, Rob Clark wrote: > On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras > wrote: >> On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark wrote: >>> On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras >>> wrote: On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark wrote: >>

[PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Felipe Contreras
On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark wrote: > On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras > wrote: >> On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark wrote: >>> diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/Makefile >>> index 9a58461..b86e6cb 100644 >>> --- a/arch/arm/pl

[PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Rob Clark
On Mon, Jan 16, 2012 at 2:37 PM, Felipe Contreras wrote: > On Mon, Jan 16, 2012 at 7:01 PM, Rob Clark wrote: >> On Mon, Jan 16, 2012 at 10:59 AM, Felipe Contreras >> wrote: >>> On Mon, Jan 16, 2012 at 6:37 PM, Rob Clark wrote: On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras wrote:

Re: [PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Rob Clark
On Mon, Jan 16, 2012 at 2:37 PM, Felipe Contreras wrote: > On Mon, Jan 16, 2012 at 7:01 PM, Rob Clark wrote: >> On Mon, Jan 16, 2012 at 10:59 AM, Felipe Contreras >> wrote: >>> On Mon, Jan 16, 2012 at 6:37 PM, Rob Clark wrote: On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras wrote:

Re: [PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Felipe Contreras
On Mon, Jan 16, 2012 at 7:01 PM, Rob Clark wrote: > On Mon, Jan 16, 2012 at 10:59 AM, Felipe Contreras > wrote: >> On Mon, Jan 16, 2012 at 6:37 PM, Rob Clark wrote: >>> On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras >>> wrote: On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark wrote: > On

[PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Rob Clark
On Mon, Jan 16, 2012 at 10:59 AM, Felipe Contreras wrote: > On Mon, Jan 16, 2012 at 6:37 PM, Rob Clark wrote: >> On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras >> wrote: >>> On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark wrote: On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras wrote:

[PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Rob Clark
On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras wrote: > On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark wrote: >> On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras >> wrote: >>> On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark wrote: diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/

Re: [PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Rob Clark
On Mon, Jan 16, 2012 at 10:59 AM, Felipe Contreras wrote: > On Mon, Jan 16, 2012 at 6:37 PM, Rob Clark wrote: >> On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras >> wrote: >>> On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark wrote: On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras wrote:

Re: [PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Felipe Contreras
On Mon, Jan 16, 2012 at 6:37 PM, Rob Clark wrote: > On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras > wrote: >> On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark wrote: >>> On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras >>> wrote: On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark wrote: > di

Re: [PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Rob Clark
On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras wrote: > On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark wrote: >> On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras >> wrote: >>> On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark wrote: diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/

Re: [PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Felipe Contreras
On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark wrote: > On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras > wrote: >> On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark wrote: >>> diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/Makefile >>> index 9a58461..b86e6cb 100644 >>> --- a/arch/arm/pl

[PATCH 1/2] omap2+: add drm device

2012-01-13 Thread Felipe Contreras
On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark wrote: > diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/Makefile > index 9a58461..b86e6cb 100644 > --- a/arch/arm/plat-omap/Makefile > +++ b/arch/arm/plat-omap/Makefile > @@ -4,7 +4,7 @@ > > ?# Common support > ?obj-y := common.o sram.o cl

[PATCH 1/2] omap2+: add drm device

2012-01-13 Thread Rob Clark
On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras wrote: > On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark wrote: >> diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/Makefile >> index 9a58461..b86e6cb 100644 >> --- a/arch/arm/plat-omap/Makefile >> +++ b/arch/arm/plat-omap/Makefile >> @@

[PATCH 1/2] omap2+: add drm device

2012-01-13 Thread Rob Clark
On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras wrote: > On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark wrote: >> diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/Makefile >> index 9a58461..b86e6cb 100644 >> --- a/arch/arm/plat-omap/Makefile >> +++ b/arch/arm/plat-omap/Makefile >> @@

[PATCH 1/2] omap2+: add drm device

2012-01-13 Thread Rob Clark
From: Rob Clark Register OMAP DRM/KMS platform device, and reserve a CMA region for the device to use for buffer allocation. v1: initial patch v2: move platform data structs into plat-omap to avoid having to #include headers from drivers/staging and cleanups Signed-off-by: Rob Clark --- No

Re: [PATCH 1/2] omap2+: add drm device

2012-01-13 Thread Rob Clark
On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras wrote: > On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark wrote: >> diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/Makefile >> index 9a58461..b86e6cb 100644 >> --- a/arch/arm/plat-omap/Makefile >> +++ b/arch/arm/plat-omap/Makefile >> @@

Re: [PATCH 1/2] omap2+: add drm device

2012-01-13 Thread Rob Clark
On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras wrote: > On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark wrote: >> diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/Makefile >> index 9a58461..b86e6cb 100644 >> --- a/arch/arm/plat-omap/Makefile >> +++ b/arch/arm/plat-omap/Makefile >> @@

Re: [PATCH 1/2] omap2+: add drm device

2012-01-13 Thread Felipe Contreras
On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark wrote: > diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/Makefile > index 9a58461..b86e6cb 100644 > --- a/arch/arm/plat-omap/Makefile > +++ b/arch/arm/plat-omap/Makefile > @@ -4,7 +4,7 @@ > >  # Common support >  obj-y := common.o sram.o cl

[PATCH 1/2] omap2+: add drm device

2012-01-13 Thread Rob Clark
From: Rob Clark Register OMAP DRM/KMS platform device, and reserve a CMA region for the device to use for buffer allocation. v1: initial patch v2: move platform data structs into plat-omap to avoid having to #include headers from drivers/staging and cleanups Signed-off-by: Rob Clark --- No