Re: [PATCH 1/3] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Koenig, Christian
Am 19.10.18 um 09:49 schrieb Daniel Vetter: > On Fri, Oct 19, 2018 at 9:38 AM Thomas Zimmermann wrote: >> Hi, >> >> thanks for the review. >> >> Am 19.10.18 um 05:30 schrieb Huang Rui: >>> On Fri, Oct 19, 2018 at 12:27:50AM +0800, Thomas Zimmermann wrote: +int ttm_global_init(struct

Re: [PATCH 1/3] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 9:38 AM Thomas Zimmermann wrote: > > Hi, > > thanks for the review. > > Am 19.10.18 um 05:30 schrieb Huang Rui: > > On Fri, Oct 19, 2018 at 12:27:50AM +0800, Thomas Zimmermann wrote: > >> +int ttm_global_init(struct ttm_global *glob) > >> +{ > >> +int ret; > >> + > > >

Re: [PATCH 1/3] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Thomas Zimmermann
Hi, thanks for the review. Am 19.10.18 um 05:30 schrieb Huang Rui: > On Fri, Oct 19, 2018 at 12:27:50AM +0800, Thomas Zimmermann wrote: >> +int ttm_global_init(struct ttm_global *glob) >> +{ >> +int ret; >> + > > We would better add a protection here to make sure the glob is not NULL. > >

Re: [PATCH 1/3] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-18 Thread Huang Rui
On Fri, Oct 19, 2018 at 12:27:50AM +0800, Thomas Zimmermann wrote: > The new struct ttm_global provides drivers with TTM's global memory and > BO in a unified way. Initialization and release is handled internally. > > The functionality provided by struct ttm_global is currently re-implemented >

[PATCH 1/3] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-18 Thread Thomas Zimmermann
The new struct ttm_global provides drivers with TTM's global memory and BO in a unified way. Initialization and release is handled internally. The functionality provided by struct ttm_global is currently re-implemented by a dozen individual DRM drivers using struct drm_global. The implementation