Re: [PATCH 1/3] drm: mediatek: fix unbind functions

2019-05-29 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2019-05-29 at 15:06 +0800, Hsin-Yi Wang wrote: > On Wed, May 29, 2019 at 9:35 AM CK Hu wrote: > > > > > I think mtk_dsi_destroy_conn_enc() has much thing to do and I would like > > you to do more. You could refer to [2] for complete implementation. > > > > [2] > > https://gi

Re: [PATCH 1/3] drm: mediatek: fix unbind functions

2019-05-29 Thread Hsin-Yi Wang
On Wed, May 29, 2019 at 9:35 AM CK Hu wrote: > > I think mtk_dsi_destroy_conn_enc() has much thing to do and I would like > you to do more. You could refer to [2] for complete implementation. > > [2] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/

Re: [PATCH 1/3] drm: mediatek: fix unbind functions

2019-05-28 Thread Hsin-Yi Wang
On Wed, May 29, 2019 at 9:35 AM CK Hu wrote: > > Hi, Hsin-yi: > > On Mon, 2019-05-27 at 12:50 +0800, Hsin-Yi Wang wrote: > > move mipi_dsi_host_unregister() to .remove since mipi_dsi_host_register() > > is called in .probe. > > In the latest kernel [1], mipi_dsi_host_register() is called in > mtk_

Re: [PATCH 1/3] drm: mediatek: fix unbind functions

2019-05-28 Thread CK Hu
Hi, Hsin-yi: On Mon, 2019-05-27 at 12:50 +0800, Hsin-Yi Wang wrote: > move mipi_dsi_host_unregister() to .remove since mipi_dsi_host_register() > is called in .probe. In the latest kernel [1], mipi_dsi_host_register() is called in mtk_dsi_bind(), I think we don't need this part. [1] https://git.

[PATCH 1/3] drm: mediatek: fix unbind functions

2019-05-26 Thread Hsin-Yi Wang
move mipi_dsi_host_unregister() to .remove since mipi_dsi_host_register() is called in .probe. detatch panel in mtk_dsi_destroy_conn_enc(), since .bind will try to attach it again. Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver") Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/